[Engine-patches] Change in ovirt-engine[master]: engine-core: [autorecovery] Autorecovery logic

[yzaslavs at redhat.com]

Yair Zaslavsky has posted comments on this change.

Change subject: engine-core: [autorecovery] Autorecovery logic
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
Line 48:     private final static Map<Guid, Date> storageDomainCunters = Collections.synchronizedMap(new HashMap<Guid, Date>());
What about previous comment on java.util.concurrent.ConcurrentMap? It's fair to disagree (if you disagree :) ) - just please respond.

Line 59:                 new Class<?>[] {}, new Object[] {}, Config.<String> GetValue(ConfigValues.AutoRecoverySchedule));
Have you considered the mechanism that moves host to NonOperational? I'm afraid that we might have collisions in host state transitions...

--
To view, visit http://gerrit.ovirt.org/2011
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I544ff69bad946fd3d4edd2cf815ad10392958d26
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>