[Engine-patches] Change in ovirt-engine[master]: gwt: Removal of SharedGwt module

[asaf at redhat.com]

Asaf Shakarchi has posted comments on this change.

Change subject: gwt: Removal of SharedGwt module
......................................................................


Patch Set 2:

The reason I added gwt-common dependency in userportal is because gwt-common contains the backend gwt descriptors for the relevant modules,
gwt-common was the best module to put them, that's the only reason I added the gwt-common dependency in userportal and yes with the provided scope it should be ok.

Regarding the version property, many other configuration properties should be shared and inherited, I am doing an overall oVirt cleanups in poms, so for sure this property  will be inherited properly.


Thanks.

--
To view, visit http://gerrit.ovirt.org/2164
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd8c8d9a64c2b661d81f46dcc95d2f166034250
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Danny Rankevich <danny.ran at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>