[Engine-patches] Change in ovirt-engine[master]: engine : Code improvements in AuditLog

masayag at redhat.com masayag at redhat.com
Sun Jan 1 07:15:23 EST 2012


Moti Asayag has submitted this change and it was merged.

Change subject: engine : Code improvements in AuditLog
......................................................................


engine : Code improvements in AuditLog

The following commit should do the following:
1. Remove unneeded memory allocations.
2. Decrease code running time - by removing unneeded run.
3. Code clean up - removed unused methods
4. Make code to look more java
5. Make class pattern shared between all threads (It is thread save due to javadoc)

Change-Id: I530dbf0d90366bb8a4511612a4aee22d761616e7
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfoTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelperTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectDescriptor.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
8 files changed, 130 insertions(+), 84 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/590
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I530dbf0d90366bb8a4511612a4aee22d761616e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>


More information about the Engine-patches mailing list