[Engine-patches] Change in ovirt-engine[master]: backend: create directory for lock file if directory is miss...

[dfediuck at redhat.com]

Doron Fediuck has posted comments on this change.

Change subject: backend: create directory for lock file if directory is missing
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File backend/manager/conf/ca/SignReq.sh
Line 68: 	mkdir -p ${lock_dir} > /dev/null
1. Please replace tab indentation with spaces.

2. Since this script runs under jboss context, you may fail
due to permissions, so you should do error-handling here,
and exit with error code, after printing the error to stderr.

3. Something to think of-
If this script is used under root context (installer?),
it will create acl issues for jboss, so as a precaution
I'd print a warning when a missing directory is being created,
and also make sure we do not have such as issue.

--
To view, visit http://gerrit.ovirt.org/1023
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I342b3034dfb37209ad20d07eeb0b472dd4aa055b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ronen Angluster <ranglust at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>