[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - support long host fqdn in create_c...

[dfediuck at redhat.com]

Doron Fediuck has posted comments on this change.

Change subject: packaging: engine-setup - support long host fqdn in create_ca (#782810)
......................................................................


Patch Set 4: (2 inline comments)

See inline

....................................................
File packaging/fedora/setup/basedefs.py
Line 143: CONST_MAX_HOST_FQDN_LEN=50
Please explain why you're not allowing the full 64 length.

....................................................
File packaging/fedora/setup/engine-setup.py
Line 783:             uniqueCN = truncatedFqdn + "." + str(randInt)
Can you add some logging here?
So we'll know how this part ended and what was supposed to be the cert' CN.

--
To view, visit http://gerrit.ovirt.org/1187
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3c5584b54afb78a28c0c22c10649d6d559e247
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Ronen Angluster <ranglust at redhat.com>