[Engine-patches] Change in ovirt-engine[master]: engine: Fix for Exception on adding new host

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Jun 10 05:30:44 EDT 2012


Omer Frenkel has posted comments on this change.

Change subject: engine: Fix for Exception on adding new host
......................................................................


Patch Set 1: I would prefer that you didn't submit this

a better approach is changing getUpServer not to throw exception, but to return null if not host (better check if null then catching exceptions)

--
To view, visit http://gerrit.ovirt.org/5149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7828145735aa12cd69fa361b947858b535838024
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>


More information about the Engine-patches mailing list