[Engine-patches] Change in ovirt-engine[master]: core: add canDoActions on several Vm flows for VmNetworks

dfediuck at redhat.com dfediuck at redhat.com
Thu Mar 8 09:15:16 EST 2012


Doron Fediuck has posted comments on this change.

Change subject: core: add canDoActions on several Vm flows for VmNetworks
......................................................................


Patch Set 11: (1 inline comment)

See inline.

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 941:         Map<String, VmNetworkInterface> interfacesByNetworkName =
Why define a map if you're only using a set?

--
To view, visit http://gerrit.ovirt.org/2476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a73545acaff56b2fe277b651f87243ec0df48d4
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>


More information about the Engine-patches mailing list