[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add session support

mpastern at redhat.com mpastern at redhat.com
Sun May 6 13:10:49 EDT 2012


Michael Pasternak has posted comments on this change.

Change subject: sdk: Add session support
......................................................................


Patch Set 2:

Hi Juan, 

nice piece of work!, but i have an issue with 
exposer of this feature to user:

end-user doesn't have direct access to proxy.request(),
- it's used only by infrastructure, actually http nature
of the sdk is abstructed by python-like objects & methods,
so user won't benefit from proxy.request(,last=...),

i.e it should be exposed via proxy constructor:
API(url, username,...,disconnect=False) and 
disconnect=False|True should be implicitly deligated
to proxy.request(,last=...)

--
To view, visit http://gerrit.ovirt.org/4044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I098f7195777ee2c93b84b9ef461044b0fc697b10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.glynn at gmail.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>


More information about the Engine-patches mailing list