[Engine-patches] Change in ovirt-engine[master]: core: Validate shared disk for export vm/template

[mkolesni at redhat.com]

Mike Kolesnik has posted comments on this change.

Change subject: core: Validate shared disk for export vm/template
......................................................................


Patch Set 8: (1 inline comment)

ExportVmTemplateCommand is a separate command but you didn't add check there so either commit message is wrong, or you missing that code..

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 192:      * Validate shared disk is not part of the VM which is export.
This doc is redundant, you can just name the method validateVmHasNoSharedDisks

--
To view, visit http://gerrit.ovirt.org/3792
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b905fedb8f32451efbdb118da9613be3931b619
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>