Findbugs issue on engine

[David Caro]

Hi Tomas!

One of your commits (not sure if  77de5a2fc23e5090934003848ceedcece29ca698 or
d19e7776918d0aba6b833c496e05630195609994) introduced a new findbugs error on
ovirt-engine/master, can you take a look please?

"""
CloneVmCommand.java:214, EC_UNRELATED_TYPES, Priority: High ç

Call to org.ovirt.engine.core.common.utils.VmDeviceType.equals(String) in
org.ovirt.engine.core.bll.CloneVmCommand.containsDeviceWithType(List,
VmDeviceGeneralType, VmDeviceType)

 This method calls equals(Object) on two references of different class types
with no common subclasses. Therefore, the objects being compared are unlikely to
be members of the same class at runtime (unless some application classes were
not analyzed, or dynamic class loading can occur at runtime). According to the
contract of equals(), objects of different classes should always compare as
unequal; therefore, according to the contract defined by
java.lang.Object.equals(Object), the result of this comparison will always be
false at runtime.
"""

Thanks!

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Email: dcaro at redhat.com
Web: www.redhat.com
RHT Global #: 82-62605

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20140410/9b56e865/attachment.sig>