Findbugs issues

[Tomas Jelinek]

merged

----- Original Message -----
> From: "Martin Perina" <mperina at redhat.com>
> To: "David Caro" <dcaroest at redhat.com>
> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "infra" <infra at ovirt.org>
> Sent: Wednesday, April 23, 2014 6:34:55 PM
> Subject: Re: Findbugs issues
> 
> 
> 
> ----- Original Message -----
> > From: "David Caro" <dcaroest at redhat.com>
> > To: "Tomas Jelinek" <tjelinek at redhat.com>, "Martin Perina"
> > <mperina at redhat.com>, "infra" <infra at ovirt.org>
> > Sent: Wednesday, April 23, 2014 6:10:03 PM
> > Subject: Findbugs issues
> > 
> > Hi!
> > 
> > There are still some findbugs issues merged on ovirt-engine master, and
> > I've
> > tracked them down to a couple commits of yours, can you please review them
> > and
> > if they were introduced there, fix them?
> > 
> > Thanks!!
> > 
> > Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina
> > HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priority:
> > Low
> > 
> > Comparison of String parameter using == or != in
> > org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpStatus(String)
> > 
> > This code compares a java.lang.String parameter for reference equality
> > using
> > the
> > == or != operators. Requiring callers to pass only String constants or
> > interned
> > strings to a method is unnecessarily fragile, and rarely leads to
> > measurable
> > performance gains. Consider using the equals(Object) method instead.
> 
> Sorry, I missed this. Patch is ready:
> 
> http://gerrit.ovirt.org/#/c/27022/
> 
> Martin
> 
> > 
> > 
> > Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek
> > VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low
> > 
> > Unread field:
> > org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPropertiesKeysList
> > 
> > This field is never read.  Consider removing it from the class.
> > 
> > 
> > pd. We have improved infra enough and we are gonna enable back the
> > per-patch
> > checks to avoid this from happening in the future so we will not bother you
> > anymore with these issues :)
> > 
> > --
> > David Caro
> > 
> > Red Hat S.L.
> > Continuous Integration Engineer - EMEA ENG Virtualization R&D
> > 
> > Email: dcaro at redhat.com
> > Web: www.redhat.com
> > RHT Global #: 82-62605
> > 
> > 
>