Invalid version of pep8 on some slaves

[Dan Kenigsberg]

On Thu, Aug 21, 2014 at 01:18:38PM -0400, Nir Soffer wrote:
> ----- Original Message -----
> > From: "David Caro" <dcaroest at redhat.com>
> > To: "Nir Soffer" <nsoffer at redhat.com>
> > Cc: "infra" <infra at ovirt.org>
> > Sent: Thursday, August 21, 2014 8:15:12 PM
> > Subject: Re: Invalid version of pep8 on some slaves
> > 
> > On 08/21, Nir Soffer wrote:
> > > Hi infra,
> > > 
> > > There is too old version of pep8 used on some slave, that cause pep8 test
> > > to fail for
> > > valid sources.
> > > 
> > > Here is one example:
> > > 
> > > http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console
> > > 
> > > gerrit failure:
> > > 
> > > + pep8 --version
> > > 1.4.5
> > > + git diff HEAD~
> > > + sed 's%^./*%%'
> > > + pep8 --diff '--filename=*.py,*.py.in,*/vdsm,*/supervdsmServer'
> > > + [[ 1 -ne 0 ]]
> > > + echo 'PEP8 Failed'
> > > PEP8 Failed
> > > + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml
> > > lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match
> > > indentation of opening bracket's line
> > > 
> > > Running pep8 on Fedora 19 (version 1.4.6):
> > 
> > That's a centos 6 slave, and it seens that's the greatest python-pep8
> > we have for centos, it's greater than the on here:
> > http://www.ovirt.org/Vdsm_Developers
> 
> David: you are correct, we need to fix the documentation.
> 
> Dan: the version on that wiki page is too old - do you have a newer build?

I don't have anything newer at the moment, though I don't really mind fast
forwarding.

On the meant while, I took myself the liberty of changing your patch to
apease the ancient pep8 gods.