DAO tests failing

[Lior Vernia]

On 24/11/14 14:25, David Caro wrote:
> On 11/24, Lior Vernia wrote:
>>
>>
>> On 24/11/14 14:16, David Caro wrote:
>>> On 11/24, Allon Mureinik wrote:
>>>> Looks like recreating the database fails:
>>>>
>>>> 08:54:54 [ovirt-engine_master_dao-unit-tests_created] $ /bin/sh /tmp/hudson8811709354471707251.sh
>>>> 08:54:54 /home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created
>>>> 08:54:54 /home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created
>>>> 08:54:55 could not change directory to "/home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created"
>>>> 08:54:55 ERROR:  role "engine" already exists
>>>> 08:54:55 could not change directory to "/home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created"
>>>> 08:54:55 ALTER ROLE
>>>> 08:54:56 could not change directory to "/home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created"
>>>> 08:54:56 dropdb: database removal failed: ERROR:  database "engine" does not exist
>>>> 08:54:56 could not change directory to "/home/jenkins/workspace/ovirt-engine_master_dao-unit-tests_created"
>>>> 08:54:58 CREATE DATABASE
>>>> 08:54:59 Creating schema engine at localhost:5432/ovirt_engine_master_dao_unit_tests_created_6082
>>>>
>>>
>>> Those are not errors, are just unfiltered messages when it tries to
>>> make sure the database is not there and the user has enough rights at
>>> the startup of the job.
>>>
>>> The first issue is:
>>>
>>> 00:09:49.369 2014-11-24 09:03:47,301 SEVERE  [org.ovirt.engine.core.dal.dbbroker.BatchProcedureExecutionConnectionCallback doInConnection] Can't execute batch: Batch entry 0 select * from public.insertnumanode(CAST ('830fd8d0-9332-4d81-bb80-54beee7d5b59' AS uuid),CAST (NULL AS uuid),CAST ('77296e00-0cad-4e5a-9299-008a7b6f4355' AS uuid),CAST ('0' AS int2),CAST ('0' AS int8),CAST ('4' AS int2),CAST (NULL AS int8),CAST (NULL AS int4),CAST (NULL AS numeric),CAST (NULL AS numeric),CAST (NULL AS numeric),CAST (NULL AS int4),CAST (NULL AS text)) as result was aborted.  Call getNextException to see the cause.
>>> 00:09:49.441 2014-11-24 09:03:47,303 SEVERE  [org.ovirt.engine.core.dal.dbbroker.BatchProcedureExecutionConnectionCallback doInConnection] Can't execute batch. Next exception is: ERROR: insert or update on table "numa_node" violates foreign key constraint "fk_numa_node_vm"
>>>
>>> What to me looks like a real issue. I'll do a couple more checks, but
>>> I don't know how the tests work or what the code does, that's your
>>> domain.
>>>
>>
>> I don't know if that specifically is a real issue or not (as it isn't
>> related to my patch and I haven't researched it), I do see however that
>> there are ultimately 433 failures and 371 errors, and that is spread
>> across many independent tests.
> 
> You should be aware that it's not just your patch that runs, but all
> the patches yours depends on, that I see are quite a lot, are you sure
> that none of them introduces those failures?
> 

It had failed the same way when it didn't depend on anything unmerged -
I recently rebased it on two other patches so I could merge them first
(and neither of them touches the dal project).

What do you mean by "quite a lot"? Do you see more than two? Could these
be environmental issues? It's possible that my patch causes all of this,
but I don't see how. Could it be the Allon's got it right, and the DB
isn't being constructed properly?

>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Lior Vernia" <lvernia at redhat.com>
>>>>> To: infra at ovirt.org
>>>>> Sent: Monday, November 24, 2014 1:37:25 PM
>>>>> Subject: DAO tests failing
>>>>>
>>>>> Hi,
>>>>>
>>>>> I've noticed recurrent failures of DAO tests on one of my patches, this
>>>>> looks like something systematic as there are hundreds of failures in
>>>>> unrelated files.
>>>>>
>>>>> http://gerrit.ovirt.org/#/c/34121/
>>>>>
>>>>> Talked to dcaro about it on Thursday, but have been rebasing and
>>>>> re-running the tests and they keep failing.
>>>>>
>>>>> Thanks, Lior.
>>>>> _______________________________________________
>>>>> Infra mailing list
>>>>> Infra at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>
>>>> _______________________________________________
>>>> Infra mailing list
>>>> Infra at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>