Jenkins CI granting excessive +1s

[dcaro]

On 06/16, Eyal Edri wrote:
> Sounds like a bug.
> Jenkins should only use the CI flag and not change CR and V flags.
> 
> Might have been a misunderstanding.
> David, can you fix it so Jenkins will only update CI flag?

Can someone pass me an example of the patch that had the reviews? It's possible
that previously the jobs were manually modified to only set the ci flag and we
updated them on yaml and the manual changes got reverted. Having a sample patch
would allow me to trim down the list of possible jobs that give that review.


That can be prevented globally easily, but until all projects have the ci flag
we can't enforce it globally.

> 
> E.
> 
> Eyal Edri
> Supervisor, RHEV CI
> Red Hat
> 
> From: Dan Kenigsberg
> Sent: Jun 16, 2015 7:06 PM
> To: infra at ovirt.org
> Cc: eedri at redhat.com; dcaro at redhat.com
> Subject: Jenkins CI granting excessive +1s
> 
> > As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for 
> > every patchset that it successfully passed. 
> >
> > Was this change somehow intentional? 
> >
> > It is confusing and unwanted. Only a human developer can give a 
> > meaningful Code-Review. Only a human user/QE can say that a patch solved 
> > the relevant bug and grant it Verfied+1. The flags that Jenkins grant 
> > are meaningless. 
> >
> > Can this be stopped? Jenkins should give CI+1 if it's happe with a 
> > patch, or CI-1 if it is has not yet run (or failed). 
> >
> > Regards, 
> > Dan. 
> >

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605
Email: dcaro at redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20150616/f15b9c63/attachment.sig>