[JIRA] (OVIRT-990) Re: Gerrit don't check for "Signed-Off" anymore

[Shlomo Ben David (oVirt JIRA)]

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25028#comment-25028 ] 

Shlomo Ben David edited comment on OVIRT-990 at 12/28/16 4:11 PM:
------------------------------------------------------------------

Projects in Gerrit can be configured to require a Signed-off-by in the footer of the commit message to enforce that every change is signed by the author, committer or uploader. If for a project a Signed-off-by is required and the commit message footer does not contain it, Gerrit rejects to push the commit with this error message.

This policy can be bypassed by having the access right 'Forge Committer'.

The 'Forge Committer' permissions were set to all Registered Users.
I set it only for 'Project Owners'.


was (Author: sbendavi at redhat.com):
Projects in Gerrit can be configured to require a Signed-off-by in the footer of the commit message to enforce that every change is signed by the author, committer or uploader. If for a project a Signed-off-by is required and the commit message footer does not contain it, Gerrit rejects to push the commit with this error message.

This policy can be bypassed by having the access right 'Forge Committer'.


> Re: Gerrit don't check for "Signed-Off" anymore
> -----------------------------------------------
>
>                 Key: OVIRT-990
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-990
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: eyal edri [Administrator]
>            Assignee: Shlomo Ben David
>
> On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <tnisan at redhat.com> wrote:
> > Last night I've push a serious of patches and forgot to sign off, up until
> > not long ago there was a hook that enforces that but it seems like it's not
> > working anymore and I was able to push the patches without the sign off:
> > https://gerrit.ovirt.org/#/c/69219/1
> >
> >
> Its not a hook, its a definition per project, each project has the
> defenition if to enforce signed-off commit:
> 'Require Signed-off-by in commit message:'  - and its on TRUE now for
> ovirt-engine, so I'm not sure how its possible that a patch got in, we'll
> need to check gerrit logs to see.
> Opening a ticket on it.
> >
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >
> -- 
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R&D
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)



--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)