Fwd: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely

[Yedidyah Bar David]

(Sorry, this time to the right address)


---------- Forwarded message ----------
From: Yedidyah Bar David <didi at redhat.com>
Date: Sun, Jan 31, 2016 at 1:20 PM
Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging:
rename: Handle storage domains more nicely
To: Jenkins CI <gerrit2 at gerrit.ovirt.org>


On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2 at gerrit.ovirt.org> wrote:
> Jenkins CI has posted comments on this change.
>
> Change subject: packaging: rename: Handle storage domains more nicely
> ......................................................................
>
>
> Patch Set 1: Continuous-Integration-1
>
> Build Failed
>
> http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ : FAILURE
>
> http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ : FAILURE

Both of these are pep8:

packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21:
E126 continuation line over-indented for hanging indent
packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21:
E126 continuation line over-indented for hanging indent

>
> http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ : SUCCESS

How come this one passed?

Do we have different versions/configuration of pep8 in different OSes?

Also note that E126 is ignored by default, see e.g.:

https://github.com/PyCQA/pep8/issues/265
https://github.com/PyCQA/pep8/pull/360

>
> --
> To view, visit https://gerrit.ovirt.org/52898
> To unsubscribe, visit https://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f
> Gerrit-PatchSet: 1
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: ovirt-engine-3.6
> Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
> Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
> Gerrit-Reviewer: Jenkins CI
> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
> Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
> Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
> Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
> Gerrit-HasComments: No



--
Didi


-- 
Didi