Gerrit hook for checking target milestone doesn't work or check wrong values

Eyal Edri eedri at redhat.com
Thu Jul 21 15:51:41 UTC 2016


Looking at the patch, I see:

   - Check TM::#1328731::OK, correct target milestone


Branch is ovirt-engine-3.6
Target Milestone is: ovirt-4.0.2

If we want that hook to give -1 or warn if there is a mismatch between
patch and target milestone then we need to fix the hook.
this should exclude master branch, since there is no target milestone for
it.


On Wed, Jul 20, 2016 at 4:10 PM, Tal Nisan <tnisan at redhat.com> wrote:

> This patch in 3.6 branch contains a 4.0.2 bug in the Bug-Url:
>
> https://gerrit.ovirt.org/#/c/60920
>
> For some reason the Gerrit hooks approved it and did not block
>
>
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>


-- 
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20160721/e9a7c1c2/attachment.html>


More information about the Infra mailing list