Duplicate upgrade scripts issue

[David Caro Estevez]

----- Original Message -----

> From: "Martin Perina" <mperina at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "Eyal Edri" <eedri at redhat.com>, "infra" <infra at ovirt.org>
> Sent: Tuesday, June 7, 2016 11:45:28 AM
> Subject: Re: Duplicate upgrade scripts issue

> On Tue, Jun 7, 2016 at 11:42 AM, Eli Mesika < emesika at redhat.com > wrote:

> > Ha , one more thing :
> 

> > We would like to force the existence of such hooks if possible ...
> 

> ​+1

> The hook should be included by default after git clone​ if possible. And if
> it's then I'd also force inclusion of commit message hook which generates
> change-id

Git does not allow 'autodownloading' hooks, you can't distribute them by git clone, the client must explicitly install them herself 

> > On Tue, Jun 7, 2016 at 12:41 PM, Eli Mesika < emesika at redhat.com > wrote:
> 

> > > Hi guys
> > 
> 

> > > I have talked with Eyal about the $Subject and he asked me to write and
> > > send
> > > this email
> > 
> 

> > > As you probably know, we have from time to time an issue with duplicate
> > > upgrade scripts that are merged by mistake, each such issue forces us to
> > > publish a fixing patch that renames the duplicated file.
> > 
> 
> > > I was discussed this issue today with Marin P on out weekly meeting
> > 
> 

> > > We would like to write some kind of a hook that will check on each patch
> > > set
> > > if it has DB upgrade files and rename them (if necessary) such that it
> > > will
> > > have the correct numbering according to the last existing upgrade patch
> > > on
> > > the related branch.
> > 
> 

> > > The hook should be done upon 'git push' request so it will also prevent
> > > CI
> > > tests to fail on this issue
> > 
> 

> > > I will be happy to get your ideas/comments on that
> > 
> 

> > > Thanks
> > 
> 

> > > Eli Mesika
> > 
> 

> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20160607/83db8486/attachment.html>