please use a single patch for a single task

Sandro Bonazzola sbonazzo at redhat.com
Fri Jan 13 22:05:43 UTC 2017


Looking at:
https://gerrit.ovirt.org/#/c/69438/3

but there are several others in gerrit for different projects
taking this one as example just because it make me loose the evening on it.

"adding cli for 4.1 experimental repos" as stated in the header of the patch
has totally nothing to do with the body of the patch:
"- also dropped fc23 since its eol"
which just dropped all the fc23 artifacts from the publisher causing:
- cockpit-ovirt for fc23 failing to build due to missing dependencies
- publisher 4.0 nightly failing due to missing cockpit-ovirt for fc23

Now I unblocked the publisher for 4.0 with: https://gerrit.ovirt.org/70402
but if infra decided to drop fc23 support since fc23 gone EOL, please do it
completely.

If a patch need a "also did..." it needs a separate patch.

Thanks,

-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20170113/fe9584c7/attachment.html>


More information about the Infra mailing list