[JIRA] (OVIRT-1430) docker images cleanup in mock_cleanup.sh is done wrong

[Daniel Belenky (oVirt JIRA)]

Daniel Belenky created OVIRT-1430:
-------------------------------------

             Summary: docker images cleanup in mock_cleanup.sh is done wrong
                 Key: OVIRT-1430
                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1430
             Project: oVirt - virtualization made easy
          Issue Type: Bug
            Reporter: Daniel Belenky
            Assignee: infra


We've decided that for now, we'll keep a cache of images coming from centos|fedora official repositories. The cleanup is done by listing all the images which are not coming from those repositories and removing them. The bug is in the way we're listing and addressing images: we're addressing images by image id's, which might be shared between several tags. For instance: if I have a Dockerfile which builds a container from the official centos image and doesn't really change the image, and then I tag the image with a different name: tag, I'll get another reference for the official image, and the cleanup will remove it.
Another issue that might come up, is that we do have an image, but its tag has changed during the ran form 'latest' to something else. In this case, the cleanup will just fail the job as it won't have find the image with the different tag that have changed.




--
This message was sent by Atlassian JIRA
(v1000.1026.0#100045)