[JIRA] (OVIRT-973) add support for custom build params on build-on-demand jobs

[Barak Korren (oVirt JIRA)]

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28914#comment-28914 ] 

Barak Korren commented on OVIRT-973:
------------------------------------

[~eedri] [~gshereme at redhat.com] The question is *when* do we want to build all permutations, what would be the conditions that cause this to be done. 

Unfortunately, setting detailed specifications from Gerrit comments is not doable currently, because AFAIK the Jenkins Gerrit plugin does not make the comment text available to running jobs. We could, however, tell patch-set events apart from comment events, so we can theoretically make "{{build-artifacts.sh}}" behave differently if it was triggered manually as opposed to automatically (We will need to think how to expose this information to the script is a useful manner).

> add support for custom build params on build-on-demand jobs
> -----------------------------------------------------------
>
>                 Key: OVIRT-973
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-973
>             Project: oVirt - virtualization made easy
>          Issue Type: Improvement
>          Components: Jenkins
>            Reporter: Greg Sheremeta
>            Assignee: infra
>              Labels: standard-ci
>
> mburman [reports|https://bugzilla.redhat.com/show_bug.cgi?id=1400010] that the nightly ovirt-engine build is missing the Chrome permutation.
> From the [build|http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/2068/consoleFull]:
> {noformat}
> 21:13:24 [INFO]    Compiling 1 permutation
> 21:13:24 [INFO]       Compiling permutation 0...
> 21:16:54 [INFO]    Compile of permutations succeeded
> {noformat}
> That should compile 2 if we want Firefox and Chrome, or 3 if we also want IE.
> mburman reports this started on November 30. I'm not sure what changed.
> Adding build flags will fix:
> DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari,gecko1_8"



--
This message was sent by Atlassian JIRA
(v1000.824.3#100035)