[JIRA] (OVIRT-1381) Re: Findbugs issues not reported correctly on Jenkins master jobs?

[Daniel Belenky (oVirt JIRA)]

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31114#comment-31114 ] 

Daniel Belenky commented on OVIRT-1381:
---------------------------------------

Ok, so with [~tnisan at redhat.com]'s help with sending a faulty patch for debugging, I was able to reproduce the issue and find the root cause.
There is another 'findbugsXml.xml' file that we were not catching in check-patch.sh due to a type.
I'll rebase my patch back to master and resend it to apply the fix.
I'll update here.


> Re: Findbugs issues not reported correctly on Jenkins master jobs?
> ------------------------------------------------------------------
>
>                 Key: OVIRT-1381
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1381
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: Gil Shinar
>            Assignee: Daniel Belenky
>
> Adding infra-support
> On Mon, May 15, 2017 at 3:55 PM, Tal Nisan <tnisan at redhat.com> wrote:
> > Just a regular "mvn findbugs:findbugs" run on master, you can revert this
> > patch and run it manually yourself: https://gerrit.ovirt.org/#/c/76820/
> >
> > On Mon, May 15, 2017 at 2:15 PM, Daniel Belenky <dbelenky at redhat.com>
> > wrote:
> >
> >> Hi Tal,
> >> I'm checking this right now.
> >> Can you provide the log from your local run? which files were exported on
> >> your local run?
> >>
> >> On Mon, May 15, 2017 at 11:51 AM Tal Nisan <tnisan at redhat.com> wrote:
> >>
> >>> I've pushed this patch to master:
> >>> https://gerrit.ovirt.org/#/c/75994/
> >>> Jenkins showed no findbugs error and I moved on to merging it
> >>>
> >>> Then I've pushed the same patch to 4.1:
> >>> https://gerrit.ovirt.org/#/c/76803/
> >>> And it resulted in two findbugs errors (though minor and style related):
> >>> http://jenkins.ovirt.org/job/ovirt-engine_4.1_find-bugs_crea
> >>> ted/898/findbugsResult/new/
> >>>
> >>> Running findbugs manually in my environment on master did report these
> >>> two issues so I'd expect the master jobs to report them as well.
> >>>
> >>> _______________________________________________
> >>> Infra mailing list
> >>> Infra at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/infra
> >>>
> >> --
> >>
> >> DANIEL BELENKY
> >>
> >> RHV DEVOPS
> >>
> >> Red Hat EMEA <https://www.redhat.com/>
> >>
> >> IRC: #rhev-integ #rhev-dev
> >> <https://red.ht/sig>
> >>
> >
> >
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >



--
This message was sent by Atlassian JIRA
(v1000.990.2#100044)