<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 31, 2015 at 1:53 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, Jul 31, 2015 at 09:13:45AM +0200, Sandro Bonazzola wrote:<br>
> On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek <<br>
> <a href="mailto:michal.skrivanek@redhat.com">michal.skrivanek@redhat.com</a>> wrote:<br>
><br>
> ><br>
> > On Jul 31, 2015, at 08:08 , Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
> ><br>
> > > Hi,<br>
> > > vdsm from 3.5 branch is currently failing to build on Fedora, failing<br>
> > pep8.<br>
> > > Please fix ASAP.<br>
> > ><br>
> > > Fedora 20:<br>
> > <a href="http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/288/artifact/exported-artifacts/build.log" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/288/artifact/exported-artifacts/build.log</a><br>
> > > Fedora 21:<br>
> > <a href="http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/114/artifact/exported-artifacts/build.log" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/114/artifact/exported-artifacts/build.log</a><br>
> ><br>
> > looks like [1] merged 3 weeks ago<br>
> ><br>
> > hm..running CI on merged patches doesn't alert on failure?<br>
> ><br>
><br>
><br>
> Looks like no email is triggered on failure since jenkins already comment<br>
> on gerrit and gerrit send an email to all people reviewing the patch.<br>
> So all of them have been warned that the patch was failing on merge.<br>
><br>
> I think vdsm is also missing a pep8 / pyflakes validation on patch sent, it<br>
> would help avoiding to discover the issue after having merged the patch.<br>
<br>
</span>We have pep8 job like that on master, but apparently - not on ovirt-3.5.<br>
<br>
Anyway, I have just posted <a href="https://gerrit.ovirt.org/#/c/44239/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/44239/</a> to<br>
unbreak the long line of [1] and other damage done for stock el7 pep8.<br>
<br>
I'll merge it asap.<br>
</blockquote></div><div class="gmail_extra"><br></div>Looks like jenkins is not happy yet.</div><div class="gmail_extra"><br><a href="http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/118/artifact/exported-artifacts/build.log">http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/118/artifact/exported-artifacts/build.log</a><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></div>