<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 10:53 AM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank" onclick="window.open('https://mail.google.com/a/https://mail.google.com/mail/u/1/?zx=h6bgwpurpc3#inbox/mail/?view=cm&tf=1&to=didi@redhat.com&cc=&bcc=&su=&body=','_blank');return false;">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Nov 17, 2015 at 10:47 AM, David Caro <<a href="mailto:dcaro@redhat.com" onclick="window.open('https://mail.google.com/a/https://mail.google.com/mail/u/1/?zx=h6bgwpurpc3#inbox/mail/?view=cm&tf=1&to=dcaro@redhat.com&cc=&bcc=&su=&body=','_blank');return false;">dcaro@redhat.com</a>> wrote:<br>
> On 11/17 10:44, Yedidyah Bar David wrote:<br>
>> See e.g. [1]. Patch was merged to master only (not to 3.6 branch), bug<br>
>> was moved to modified. When I later pushed the patch to 3.6, it<br>
>> correctly moved it back to POST. Not sure we should even automatically<br>
>> move to modified if merged to 3.6, because there might be other<br>
>> changes needed for that bug - it might be best to let the owner to<br>
>> decide.<br>
><br>
> The issue here is that there's no way for the hooks to know that you will be<br>
> pushing more patches, so when it saw that there were no more open patches it<br>
> moved the bug to MODIFIED. Is there any reason why you did not open the patches<br>
> first?<br>
<br>
</span>There are two different issues here:<br>
<br>
1. If merging to master branch, and bug is 3.6, bug should not be<br>
moved to modified<br>
at all.<br></blockquote><div><br></div><div>imo, the gerrit hook should give -1 on this. </div><div>either don't put bug-url at all, or put 4.0 bug-url.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
2. If merging to 3.6 branch, and bug is 3.6, we might or might not<br>
want to move to<br>
modified. Not always people push all patches at once - sometimes they<br>
prefer to have<br>
some preparation patch merged (perhaps after a long review process, during which<br>
the patch is changed quite a lot), then continue with more patches. This wasn't<br>
current case, although I still think we might want to open it to discussion.<br></blockquote><div><br></div><div>i replied on this on the previous reply</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">--<br>
Didi<br>
_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" onclick="window.open('https://mail.google.com/a/https://mail.google.com/mail/u/1/?zx=h6bgwpurpc3#inbox/mail/?view=cm&tf=1&to=Infra@ovirt.org&cc=&bcc=&su=&body=','_blank');return false;">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Eyal Edri<br>Supervisor, RHEV CI<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div>
</div></div>