<div dir="ltr"><div>On Wed, Dec 9, 2015 at 10:05 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">+1,<div>this will be the best suggestion.</div><div>we can try adding a manual trigger for drafts if needed, still need to check if possible.</div><div><br></div><div>e.</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Wed, Dec 9, 2015 at 9:38 AM, Eli Mesika <span dir="ltr"><<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span><br>
<br>
----- Original Message -----<br>
> From: "Barak Korren" <<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>><br>
> To: "Amit Aviram" <<a href="mailto:aaviram@redhat.com" target="_blank">aaviram@redhat.com</a>><br>
> Cc: "infra" <<a href="mailto:infra@ovirt.org" target="_blank">infra@ovirt.org</a>><br>
> Sent: Tuesday, December 8, 2015 5:16:30 PM<br>
> Subject: Re: Actively triggering of CI jobs<br>
><br>
> > I was thinking, maybe it would be better if we will explicitly require to<br>
> > run the CI jobs when we push patches.. then only when the developer will<br>
> > need the job's feedback it will be activated. no redundant jobs will run,<br>
> > and we will wait much less for the jobs to finish when we will actually<br>
> > need<br>
> > them.<br>
<br>
</span>Why not simply submit your patches as a Draft until the point you want CI to run on them, then you can simply publish them ...<br>
This is the way I am using and it's simple ...<br>
<div><div><br>
> ><br>
> It seems to me that it will me too easy to forget to run the CI this way.<br>
</div></div></blockquote></div></div></div></div></blockquote><div>We barely merge patches that did not pass the CI tests.. only if it fails on general errors that doesn't belong the patch's context. but it is part of the developing process, we can't just forget to using it. that means that it is mandatory to run it at some point if a developer wants his patches to be merged. which means the developer runs it <b>only</b> when it is ready to be merged. (much much less triggered jobs!) </div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_extra"><div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>><br>
> There is another way though - To make the jobs do a lot less work.<br>
> Most anything has to do what what actually happens in CI resides in<br>
> the project`s automation directory now days (see [1]). If you want to<br>
> make CI smarter so it will not do things it shouldn't be doing, all<br>
> you need to do is customize the automation scripts to be smarter and<br>
> run only the needed tests for the files that were changed by the<br>
> patch.<br>
><br>
> [1]: <a href="http://www.ovirt.org/CI/Build_and_test_standards" rel="noreferrer" target="_blank">http://www.ovirt.org/CI/Build_and_test_standards</a><br>
><br></div></div></blockquote></div></div></div></div></blockquote><div>That's nice, but most of us are not aware of all that..</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_extra"><div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>
> --<br>
> Barak Korren<br>
> <a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a><br>
> RHEV-CI Team<br>
> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
><br>
_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class=""><font color="#888888">-- <br><div>Eyal Edri<br>Supervisor, RHEV CI<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div>
</font></span></div>
</blockquote></div><br></div><div class="gmail_extra">From what I'm seeing, most of the developers here don't make their patches drafts.. moreover, <div>- personally I didn't even know that it will not trigger jobs if it is a draft. (and I'm not the only one)</div><div>- sometimes I need to label my patches, therefor can't make it a draft</div><div><br></div><div>nowadays we are waiting for the jobs too much to finish. and the reality is that too much jobs shouldn't run at all- despite all of the nice things you guys show here..</div><div><br></div><div>I still think that it will be a better solution to force the developer to activate the tests manually (by adding a flag when pushing or even doing it with the jenkins client..)</div><div><br></div><div> </div><div><br></div></div></div>