<div dir="ltr">adding also infra team for visibility on the change in CI.<div>also inline.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani <span dir="ltr"><<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">----- Original Message -----<br>
> From: "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> To: <a href="mailto:devel@ovirt.org">devel@ovirt.org</a>, "Francesco Romani" <<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>>, "Nir Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>>, "Piotr Kliczewski"<br>
> <<a href="mailto:pkliczew@redhat.com">pkliczew@redhat.com</a>><br>
> Cc: "danken" <<a href="mailto:danken@redhat.com">danken@redhat.com</a>>, "David Caro" <<a href="mailto:dcaroest@redhat.com">dcaroest@redhat.com</a>>, "Eyal Edri" <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>><br>
> Sent: Thursday, December 10, 2015 6:46:37 PM<br>
> Subject: Automation CI for vdsm<br>
<br>
[...]<br>
<span class="">> We want to allow developers to trigger the script once reviews and<br>
> verification are ready (last step before merge). To do so we agreed to add<br>
> Continues Integration flag for each vdsm patch. </span></blockquote><div><br></div><div>This flag will be called 'Workflow' or we can name it otherwise, we just need to choose what makes sense. </div><div>David/Yaniv - Please correct me if I'm wrong.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Once this flag will be<br>
> signed with +1 it will trigger Jenkins CI to run the check-merged script<br>
> (adding new button to gerrit is not an option - you can image that flag as<br>
> a trigger button), on success Jenkins CI flag will turn to +2. on fail<br>
> we'll get -1 and once new patchset is ready the developer will remove the<br>
> +1 and add it back to the Continues Integration flag to re-trigger the job.<br>
><br>
> Please ack the process before we move on with that<br>
<br>
</span>Sounds good, even though I'm a little scared (just gut feeling, no evidence<br>
whatsoever) that this could add even more complexity and fragility to the jenkins<br>
fleet.<br>
<br>
In the long run, when this is reliable, it will help greatly.<br>
In the short term, I'm scared because this can lead to false positives and bogus<br>
failures.<br>
<br>
Let me stress I don't have concrete item to share or specific flaws.<br>
<br>
As action item on me, I will find some time next week to check virt functional tests,<br>
to see if they need some fixes, work reliably and so forth<br>
<span class=""><br>
> The patch for those scripts still under review and testing -<br>
> <a href="https://gerrit.ovirt.org/#/c/48268" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/48268</a><br>
<br>
</span>Will review asap.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Francesco Romani<br>
RedHat Engineering Virtualization R & D<br>
Phone: 8261328<br>
IRC: fromani<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Eyal Edri<br>Supervisor, RHEV CI<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div>
</div></div>