<div dir="ltr">OK. so for now the patch [1] skips all storage and OVSNetwork tests<div>Which still doesn&#39;t help much, single run takes more than 3hrs :/ (1:17hr, for the setup :\ the rest for the tests)</div><div><br><div>The output looks pretty good though :)</div><div><br></div><div>[1] <a href="https://gerrit.ovirt.org/#/c/48268/">https://gerrit.ovirt.org/#/c/48268/</a></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 17, 2015 at 12:13 PM, Petr Horacek <span dir="ltr">&lt;<a href="mailto:phoracek@redhat.com" target="_blank">phoracek@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
OVSNetworkTest requires vdsm-hook-ovs installed (tests are not skipped<br>
if the package is not installed) and openvswitch service running (not<br>
started automatically). NetworkTest are not able to run together with<br>
OVSNetworkTest since we are doing ugly inheritance hacking there. My<br>
apologize for network tests difficulties, it will be resolved soon. If<br>
you want your life easier, temporary skip OVSNetworkTest suite and it<br>
should be OK.<br>
<br>
Best regards,<br>
Petr<br>
<div><div class="h5"><br>
2015-12-16 17:25 GMT+01:00 Yaniv Bronheim &lt;<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>&gt;:<br>
&gt; exactly - just posted a patch again that sings all fails as broken .<br>
&gt; we&#39;ll get the report soon and I&#39;ll publish it as well. hope the run will<br>
&gt; take less time now<br>
&gt;<br>
&gt; On Wed, Dec 16, 2015 at 6:19 PM, Nir Soffer &lt;<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Nice, but we cannot enable this until all the tests pass or disabled.<br>
&gt;&gt;<br>
&gt;&gt; There is no point in broken or flaky functional tests.<br>
&gt;&gt;<br>
&gt;&gt; On Wed, Dec 16, 2015 at 5:34 PM, Yaniv Bronheim &lt;<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>&gt;<br>
&gt;&gt; wrote:<br>
&gt;&gt; &gt; So its not stable. It won&#39;t block merges and at least give us report<br>
&gt;&gt; &gt; after<br>
&gt;&gt; &gt; each merge. It takes really long time to run it (because of the tests<br>
&gt;&gt; &gt; themselves. Lago things takes maximum 15minutes, but the run last for<br>
&gt;&gt; &gt; more<br>
&gt;&gt; &gt; than 2hrs right now and I suspect functional/storageTests.py gets stuck)<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Bellow you can see where we stand (before I added python-rtslib<br>
&gt;&gt; &gt; package).<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Now, I still want to merge the patch <a href="https://gerrit.ovirt.org/#/c/48268/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/48268/</a><br>
&gt;&gt; &gt; -<br>
&gt;&gt; &gt; which enables this run after merges, and I still want you to consider<br>
&gt;&gt; &gt; the<br>
&gt;&gt; &gt; addition of Automation CI flag to our gerrit so that developer will be<br>
&gt;&gt; &gt; able<br>
&gt;&gt; &gt; to use it as a trigger for the check-merged.sh script run, just to see<br>
&gt;&gt; &gt; if<br>
&gt;&gt; &gt; their patch fixes\brakes something realted to the functional tests<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; <a href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/</a> -<br>
&gt;&gt; &gt; is<br>
&gt;&gt; &gt; an example of how the run looks like. I still work to improve the output<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; Please reply and let me know if the idea around the automation flag is<br>
&gt;&gt; &gt; acceptable by you.. and please review the patch for comments and acks.<br>
&gt;&gt; &gt; We can ask dcaro to add the flag until Friday, otherwise we&#39;ll need to<br>
&gt;&gt; &gt; delay<br>
&gt;&gt; &gt; this effort after the holiday..<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; functional.sosPluginTests.SosPluginTest<br>
&gt;&gt; &gt;     testSosPlugin                                               OK<br>
&gt;&gt; &gt; functional.vmRecoveryTests.RecoveryTests<br>
&gt;&gt; &gt;     test_vm_recovery                                            FAIL<br>
&gt;&gt; &gt; functional.vmQoSTests.VMQosTests<br>
&gt;&gt; &gt;     testSmallVMBallooning                                       FAIL<br>
&gt;&gt; &gt; functional.virtTests.VirtTest<br>
&gt;&gt; &gt;     testComplexVm                                               FAIL<br>
&gt;&gt; &gt;     testHeadlessVm                                              OK<br>
&gt;&gt; &gt;     testSimpleVm                                                FAIL<br>
&gt;&gt; &gt;     testVmDefinitionGraphics(&#39;spice&#39;)                           FAIL<br>
&gt;&gt; &gt;     testVmDefinitionGraphics(&#39;vnc&#39;)                             OK<br>
&gt;&gt; &gt;     testVmDefinitionLegacyGraphics(&#39;qxl&#39;)                       FAIL<br>
&gt;&gt; &gt;     testVmDefinitionLegacyGraphics(&#39;vnc&#39;)                       OK<br>
&gt;&gt; &gt;     testVmDefinitionMultipleGraphics(&#39;spice&#39;, &#39;vnc&#39;)            FAIL<br>
&gt;&gt; &gt;     testVmDefinitionMultipleGraphics(&#39;vnc&#39;, &#39;spice&#39;)            FAIL<br>
&gt;&gt; &gt;     testVmWithCdrom(&#39;self&#39;)                                     FAIL<br>
&gt;&gt; &gt;     testVmWithCdrom(&#39;specParams&#39;)                               FAIL<br>
&gt;&gt; &gt;     testVmWithCdrom(&#39;vmPayload&#39;)                                FAIL<br>
&gt;&gt; &gt;     testVmWithDevice(&#39;hotplugDisk&#39;)                             FAIL<br>
&gt;&gt; &gt;     testVmWithDevice(&#39;hotplugNic&#39;)                              FAIL<br>
&gt;&gt; &gt;     testVmWithDevice(&#39;smartcard&#39;)                               FAIL<br>
&gt;&gt; &gt;     testVmWithDevice(&#39;virtioNic&#39;)                               FAIL<br>
&gt;&gt; &gt;     testVmWithDevice(&#39;virtioRng&#39;)                               FAIL<br>
&gt;&gt; &gt;     testVmWithSla                                               FAIL<br>
&gt;&gt; &gt;     testVmWithStorage(&#39;iscsi&#39;)                                  SKIP:<br>
&gt;&gt; &gt; python-rtslib is not installed.<br>
&gt;&gt; &gt;     testVmWithStorage(&#39;localfs&#39;)                                FAIL<br>
&gt;&gt; &gt;     testVmWithStorage(&#39;nfs&#39;)                                    FAIL<br>
&gt;&gt; &gt; functional.storageTests.StorageTest<br>
&gt;&gt; &gt;     testCreatePoolErrors                                        OK<br>
&gt;&gt; &gt;     testStorage(&#39;glusterfs&#39;, 0)                                 ERROR<br>
&gt;&gt; &gt;     testStorage(&#39;glusterfs&#39;, 3)                                 ERROR<br>
&gt;&gt; &gt;     testStorage(&#39;iscsi&#39;, 0)                                     SKIP:<br>
&gt;&gt; &gt; python-rtslib is not installed.<br>
&gt;&gt; &gt;     testStorage(&#39;iscsi&#39;, 3)                                     SKIP:<br>
&gt;&gt; &gt; python-rtslib is not installed.<br>
&gt;&gt; &gt;     testStorage(&#39;localfs&#39;, 0)                                   FAIL<br>
&gt;&gt; &gt;     testStorage(&#39;localfs&#39;, 3)                                   FAIL<br>
&gt;&gt; &gt;     testStorage(&#39;nfs&#39;, 0)                                       FAIL<br>
&gt;&gt; &gt;     testStorage(&#39;nfs&#39;, 3)                                       FAIL<br>
&gt;&gt; &gt; functional.networkTests.NetworkTest<br>
&gt;&gt; &gt;     testAddVlanedBridgeless                                     ERROR<br>
&gt;&gt; &gt;     testAddVlanedBridgeless_oneCommand                          ERROR<br>
&gt;&gt; &gt;     testAfterNetworkSetupHook                                   ERROR<br>
&gt;&gt; &gt;     testBeforeNetworkSetupHook                                  ERROR<br>
&gt;&gt; &gt;     testBondHwAddress(False)                                    ERROR<br>
&gt;&gt; &gt;     testBondHwAddress(True)                                     ERROR<br>
&gt;&gt; &gt;     testBrokenNetworkReplacement(False)                         ERROR<br>
&gt;&gt; &gt;     testBrokenNetworkReplacement(True)                          ERROR<br>
&gt;&gt; &gt;     testDelNetworkBondAccumulation                              ERROR<br>
&gt;&gt; &gt;     testDelNetworkWithMTU(False)                                ERROR<br>
&gt;&gt; &gt;     testDelNetworkWithMTU(True)                                 ERROR<br>
&gt;&gt; &gt;     testDelWithoutAdd                                           ERROR<br>
&gt;&gt; &gt;     testDhclientLeases(4, &#39;default&#39;)                            ERROR<br>
&gt;&gt; &gt;     testDhclientLeases(4, &#39;local&#39;)                              ERROR<br>
&gt;&gt; &gt;     testDhclientLeases(6, None)                                 ERROR<br>
&gt;&gt; &gt;     testDhcpReplaceNicWithBridge                                ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidBondingName(False)                       ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidBondingName(True)                        ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidBridgeName                               ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidIpConfig                                 ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidNic(False)                               ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidNic(True)                                ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidParams(False)                            ERROR<br>
&gt;&gt; &gt;     testFailWithInvalidParams(True)                             ERROR<br>
&gt;&gt; &gt;     testGetRouteDeviceTo                                        ERROR<br>
&gt;&gt; &gt;     testHonorBlockingDhcp                                       SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testIpLinkWrapper                                           ERROR<br>
&gt;&gt; &gt;     testLowerMtuDoesNotOverride                                 FAIL<br>
&gt;&gt; &gt;     testNoBridgeLeftovers                                       FAIL<br>
&gt;&gt; &gt;     testReconfigureBrNetWithVanishedPort                        ERROR<br>
&gt;&gt; &gt;     testRedefineBondedNetworkIPs                                ERROR<br>
&gt;&gt; &gt;     testRemovingBridgeDoesNotLeaveBridge                        ERROR<br>
&gt;&gt; &gt;     testReorderBondingOptions(False)                            ERROR<br>
&gt;&gt; &gt;     testReorderBondingOptions(True)                             ERROR<br>
&gt;&gt; &gt;     testRestoreNetworksOnlyRestoreUnchangedDevices              ERROR<br>
&gt;&gt; &gt;     testRestoreToBlockingDHCP                                   ERROR<br>
&gt;&gt; &gt;     testSafeNetworkConfig(False)                                ERROR<br>
&gt;&gt; &gt;     testSafeNetworkConfig(True)                                 ERROR<br>
&gt;&gt; &gt;     testSelectiveRestoreDuringUpgrade                           ERROR<br>
&gt;&gt; &gt;     testSelectiveRestoreIgnoresVdsmRegParams                    FAIL<br>
&gt;&gt; &gt;     testSetupNetworkOutboundQos(False)                          ERROR<br>
&gt;&gt; &gt;     testSetupNetworkOutboundQos(True)                           FAIL<br>
&gt;&gt; &gt;     testSetupNetworksActiveSlave                                ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddBadParams(False)                        ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddBadParams(True)                         FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddBondWithManyVlans(False)                ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddBondWithManyVlans(True)                 FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelBondedNetwork(False)                 ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddDelBondedNetwork(True)                  FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(False, (4, 6))                  ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(False, (4,))                    ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(False, (6,))                    ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (4, 6))                   FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (4,))                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (6,))                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddManyVlans(False)                        ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddManyVlans(True)                         FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddNetworkToNicAfterBondBreaking(False)    ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddNetworkToNicAfterBondBreaking(True)     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddNetworkToNicAfterBondResizing(False)    ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddNetworkToNicAfterBondResizing(True)     ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddOverExistingBond(False)                 ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddOverExistingBond(True)                  ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddVlan(False)                             ERROR<br>
&gt;&gt; &gt;     testSetupNetworksAddVlan(True)                              FAIL<br>
&gt;&gt; &gt;     testSetupNetworksConnectivityCheck                          FAIL<br>
&gt;&gt; &gt;     testSetupNetworksConvertVlanNetBridgeness                   ERROR<br>
&gt;&gt; &gt;     testSetupNetworksDelOneOfBondNets                           ERROR<br>
&gt;&gt; &gt;     testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured   ERROR<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupBondOverwrite(False)ERROR<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupBondOverwrite(True) SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(False)ERROR<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(True) SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testSetupNetworksKeepNetworkOnBondAfterBondResizing(False)  ERROR<br>
&gt;&gt; &gt;     testSetupNetworksKeepNetworkOnBondAfterBondResizing(True)   FAIL<br>
&gt;&gt; &gt;     testSetupNetworksMtus(False)                                ERROR<br>
&gt;&gt; &gt;     testSetupNetworksMtus(True)                                 SKIP:<br>
&gt;&gt; &gt; This<br>
&gt;&gt; &gt; test fails because the 2 different networks are getting configured with<br>
&gt;&gt; &gt; the<br>
&gt;&gt; &gt; same MTU. The test should assert that the reported MTUs are equal to the<br>
&gt;&gt; &gt; requested ones.<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverBond(False)                   ERROR<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverBond(True)                    FAIL<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverNic(False)                    ERROR<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverNic(True)                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksNetCompatibilityMultipleNetsSameNic(False) ERROR<br>
&gt;&gt; &gt;     testSetupNetworksNetCompatibilityMultipleNetsSameNic(True)  FAIL<br>
&gt;&gt; &gt;     testSetupNetworksNicless                                    FAIL<br>
&gt;&gt; &gt;     testSetupNetworksNiclessBridgeless                          ERROR<br>
&gt;&gt; &gt;     testSetupNetworksOverDhcpIface                              ERROR<br>
&gt;&gt; &gt;     testSetupNetworksOverExistingBridge                         FAIL<br>
&gt;&gt; &gt;     testSetupNetworksReconfigureBridge                          FAIL<br>
&gt;&gt; &gt;     testSetupNetworksRemoveBondWithKilledEnslavedNics           ERROR<br>
&gt;&gt; &gt;     testSetupNetworksRemoveSlavelessBond                        ERROR<br>
&gt;&gt; &gt;     testSetupNetworksResizeBond(False)                          ERROR<br>
&gt;&gt; &gt;     testSetupNetworksResizeBond(True)                           ERROR<br>
&gt;&gt; &gt;     testSetupNetworksStableBond(False)                          ERROR<br>
&gt;&gt; &gt;     testSetupNetworksStableBond(True)                           ERROR<br>
&gt;&gt; &gt;     testStaticNetworkConfig((4, 6))                             FAIL<br>
&gt;&gt; &gt;     testStaticNetworkConfig((4,))                               FAIL<br>
&gt;&gt; &gt;     testStaticNetworkConfig((6,))                               FAIL<br>
&gt;&gt; &gt;     testStaticSourceRouting(False)                              ERROR<br>
&gt;&gt; &gt;     testStaticSourceRouting(True)                               FAIL<br>
&gt;&gt; &gt;     testTwiceAdd(False)                                         ERROR<br>
&gt;&gt; &gt;     testTwiceAdd(True)                                          ERROR<br>
&gt;&gt; &gt;     testVolatileConfig(False)                                   ERROR<br>
&gt;&gt; &gt;     testVolatileConfig(True)                                    ERROR<br>
&gt;&gt; &gt;     test_drop_initial_bond_slaves_ip_config                     FAIL<br>
&gt;&gt; &gt;     test_getVdsStats                                            ERROR<br>
&gt;&gt; &gt;     test_remove_bond_under_network                              FAIL<br>
&gt;&gt; &gt;     test_remove_initial_network_nic_ip_config                   FAIL<br>
&gt;&gt; &gt;     test_rollback                                               FAIL<br>
&gt;&gt; &gt;     test_setupNetworks_bond_with_custom_option                  ERROR<br>
&gt;&gt; &gt;     test_setupNetworks_on_external_bond                         ERROR<br>
&gt;&gt; &gt;     test_setupNetworks_on_external_vlaned_bond                  ERROR<br>
&gt;&gt; &gt; functional.networkTestsOVS.OVSNetworkTest<br>
&gt;&gt; &gt;     testHonorBlockingDhcp                                       SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testLowerMtuDoesNotOverride                                 OK<br>
&gt;&gt; &gt;     testNoBridgeLeftovers                                       FAIL<br>
&gt;&gt; &gt;     testSelectiveRestoreIgnoresVdsmRegParams                    FAIL<br>
&gt;&gt; &gt;     testSetupNetworkOutboundQos(True)                           OK<br>
&gt;&gt; &gt;     testSetupNetworksAddBadParams(True)                         OK<br>
&gt;&gt; &gt;     testSetupNetworksAddBondWithManyVlans(True)                 FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelBondedNetwork(True)                  FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (4, 6))                   FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (4,))                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddDelDhcp(True, (6,))                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddManyVlans(True)                         OK<br>
&gt;&gt; &gt;     testSetupNetworksAddNetworkToNicAfterBondBreaking(True)     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksAddVlan(True)                              FAIL<br>
&gt;&gt; &gt;     testSetupNetworksConnectivityCheck                          OK<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupBondOverwrite(True) SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(True) SKIP:<br>
&gt;&gt; &gt; Slow<br>
&gt;&gt; &gt; tests are disabled<br>
&gt;&gt; &gt;     testSetupNetworksKeepNetworkOnBondAfterBondResizing(True)   FAIL<br>
&gt;&gt; &gt;     testSetupNetworksMtus(True)                                 SKIP:<br>
&gt;&gt; &gt; This<br>
&gt;&gt; &gt; test fails because the 2 different networks are getting configured with<br>
&gt;&gt; &gt; the<br>
&gt;&gt; &gt; same MTU. The test should assert that the reported MTUs are equal to the<br>
&gt;&gt; &gt; requested ones.<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverBond(True)                    FAIL<br>
&gt;&gt; &gt;     testSetupNetworksMultiMTUsOverNic(True)                     FAIL<br>
&gt;&gt; &gt;     testSetupNetworksNetCompatibilityMultipleNetsSameNic(True)  FAIL<br>
&gt;&gt; &gt;     testSetupNetworksNicless                                    OK<br>
&gt;&gt; &gt;     testSetupNetworksOverExistingBridge                         OK<br>
&gt;&gt; &gt;     testSetupNetworksReconfigureBridge                          FAIL<br>
&gt;&gt; &gt;     testStaticNetworkConfig((4, 6))                             FAIL<br>
&gt;&gt; &gt;     testStaticNetworkConfig((4,))                               FAIL<br>
&gt;&gt; &gt;     testStaticNetworkConfig((6,))                               FAIL<br>
&gt;&gt; &gt;     testStaticSourceRouting(True)                               FAIL<br>
&gt;&gt; &gt;     test_drop_initial_bond_slaves_ip_config                     FAIL<br>
&gt;&gt; &gt;     test_ovirtmgmtm_to_ovs                                      FAIL<br>
&gt;&gt; &gt;     test_remove_bond_under_network                              SKIP:<br>
&gt;&gt; &gt; OVS<br>
&gt;&gt; &gt; does not support bridgeless networks<br>
&gt;&gt; &gt;     test_remove_initial_network_nic_ip_config                   OK<br>
&gt;&gt; &gt;     test_rollback                                               FAIL<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; On Sun, Dec 13, 2015 at 10:07 PM, Piotr Kliczewski &lt;<a href="mailto:pkliczew@redhat.com">pkliczew@redhat.com</a>&gt;<br>
&gt;&gt; &gt; wrote:<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; I like the idea but I have the same feelings as Francesco. I think that<br>
&gt;&gt; &gt;&gt; we<br>
&gt;&gt; &gt;&gt; need to make sure that functional tests for each vertical are stable<br>
&gt;&gt; &gt;&gt; before<br>
&gt;&gt; &gt;&gt; enabling this process.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; On Sun, Dec 13, 2015 at 8:34 AM, Eyal Edri &lt;<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>&gt; wrote:<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt; adding also infra team for visibility on the change in CI.<br>
&gt;&gt; &gt;&gt;&gt; also inline.<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt; On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani &lt;<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>&gt;<br>
&gt;&gt; &gt;&gt;&gt; wrote:<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; ----- Original Message -----<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; From: &quot;Yaniv Bronheim&quot; &lt;<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; To: <a href="mailto:devel@ovirt.org">devel@ovirt.org</a>, &quot;Francesco Romani&quot; &lt;<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>&gt;, &quot;Nir<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Soffer&quot; &lt;<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>&gt;, &quot;Piotr Kliczewski&quot;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; &lt;<a href="mailto:pkliczew@redhat.com">pkliczew@redhat.com</a>&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Cc: &quot;danken&quot; &lt;<a href="mailto:danken@redhat.com">danken@redhat.com</a>&gt;, &quot;David Caro&quot;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; &lt;<a href="mailto:dcaroest@redhat.com">dcaroest@redhat.com</a>&gt;,<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; &quot;Eyal Edri&quot; &lt;<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Sent: Thursday, December 10, 2015 6:46:37 PM<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Subject: Automation CI for vdsm<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; [...]<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; We want to allow developers to trigger the script once reviews and<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; verification are ready (last step before merge). To do so we agreed<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; to<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; add<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Continues Integration flag for each vdsm patch.<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt; This flag will be called &#39;Workflow&#39; or we can name it otherwise, we<br>
&gt;&gt; &gt;&gt;&gt; just<br>
&gt;&gt; &gt;&gt;&gt; need to choose what makes sense.<br>
&gt;&gt; &gt;&gt;&gt; David/Yaniv - Please correct me if I&#39;m wrong.<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; Once this flag will be<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; signed with +1 it will trigger Jenkins CI to run the check-merged<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; script<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; (adding new button to gerrit is not an option - you can image that<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; flag as<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; a trigger button), on success Jenkins CI flag will turn to +2. on<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; fail<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; we&#39;ll get -1 and once new patchset is ready the developer will<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; remove<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; the<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; +1 and add it back to the Continues Integration flag to re-trigger<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; the<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; job.<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; Please ack the process before we move on with that<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; Sounds good, even though I&#39;m a little scared (just gut feeling, no<br>
&gt;&gt; &gt;&gt;&gt;&gt; evidence<br>
&gt;&gt; &gt;&gt;&gt;&gt; whatsoever) that this could add even more complexity and fragility to<br>
&gt;&gt; &gt;&gt;&gt;&gt; the jenkins<br>
&gt;&gt; &gt;&gt;&gt;&gt; fleet.<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; In the long run, when this is reliable, it will help greatly.<br>
&gt;&gt; &gt;&gt;&gt;&gt; In the short term, I&#39;m scared because this can lead to false<br>
&gt;&gt; &gt;&gt;&gt;&gt; positives<br>
&gt;&gt; &gt;&gt;&gt;&gt; and bogus<br>
&gt;&gt; &gt;&gt;&gt;&gt; failures.<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; Let me stress I don&#39;t have concrete item to share or specific flaws.<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; As action item on me, I will find some time next week to check virt<br>
&gt;&gt; &gt;&gt;&gt;&gt; functional tests,<br>
&gt;&gt; &gt;&gt;&gt;&gt; to see if they need some fixes, work reliably and so forth<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; The patch for those scripts still under review and testing -<br>
&gt;&gt; &gt;&gt;&gt;&gt; &gt; <a href="https://gerrit.ovirt.org/#/c/48268" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/48268</a><br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; Will review asap.<br>
&gt;&gt; &gt;&gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;&gt; --<br>
&gt;&gt; &gt;&gt;&gt;&gt; Francesco Romani<br>
&gt;&gt; &gt;&gt;&gt;&gt; RedHat Engineering Virtualization R &amp; D<br>
&gt;&gt; &gt;&gt;&gt;&gt; Phone: 8261328<br>
&gt;&gt; &gt;&gt;&gt;&gt; IRC: fromani<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt; --<br>
&gt;&gt; &gt;&gt;&gt; Eyal Edri<br>
&gt;&gt; &gt;&gt;&gt; Supervisor, RHEV CI<br>
&gt;&gt; &gt;&gt;&gt; EMEA ENG Virtualization R&amp;D<br>
&gt;&gt; &gt;&gt;&gt; Red Hat Israel<br>
&gt;&gt; &gt;&gt;&gt;<br>
&gt;&gt; &gt;&gt;&gt; phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
&gt;&gt; &gt;&gt;&gt; irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; --<br>
&gt;&gt; &gt; Yaniv Bronhaim.<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; --<br>
&gt; Yaniv Bronhaim.<br>
&gt;<br>
</div></div>&gt; _______________________________________________<br>
&gt; Devel mailing list<br>
&gt; <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
&gt; <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div>