<div dir="ltr">I've created a new spreadhsheet [1] with existing hooks.<div>Please review and comment on the current logic, and also on new logic or new hooks needed.</div><div><br></div><div>Once we'll have everything sorted out we can plan how to update any hook if needed.</div><div><br></div><div>[1] <a href="https://docs.google.com/spreadsheets/d/1M-wiXpxX8lWtLRyOv2KZOCMlXJJLHVnWsTuh9_FBpN0/edit?usp=sharing">https://docs.google.com/spreadsheets/d/1M-wiXpxX8lWtLRyOv2KZOCMlXJJLHVnWsTuh9_FBpN0/edit?usp=sharing</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 3, 2016 at 9:15 AM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 02/03 08:55, Eyal Edri wrote:<br>
> Do we have a place where all the current logic of the hooks is described?<br>
> I can use it as a base and adjust each one to the new logic we need.<br>
<br>
</span>Not really, we have the code, but the task to properly document was never<br>
finished (in part because it's been changing quite often) and the task to<br>
puppetize has been in the backburner (also because gerrit itself is not in<br>
puppet, so it's not straight-forward).<br>
<br>
The best you can do is go to gerrit through ssh (port 22) and ls<br>
/home/gerrit2/review_site/git/ovirt-engine.git/hooks.<br>
<br>
<br>
[root@gerrit ~]# ls /home/gerrit2/review_site/git/ovirt-engine.git/hooks/change-abandoned.update_tracker<br>
change-merged.set_MODIFIED<br>
change-merged.update_tracker<br>
comment-added.propagate_review_values<br>
config<br>
patchset-created.bz.0.has_bug_url<br>
patchset-created.bz.1.is_public<br>
patchset-created.bz.2.correct_product<br>
patchset-created.bz.3.correct_target_milestone<br>
patchset-created.bz.98.set_POST<br>
patchset-created.bz.99.review_ok<br>
patchset-created.update_tracker<br>
patchset-created.warn_if_not_merged_to_previous_branch<br>
update_tracker<br>
<br>
<br>
For the config you have:<br>
<br>
## Branches to take into account<br>
BRANCHES=('ovirt-engine-3.6' 'ovirt-engine-3.6.0' 'ovirt-engine-3.6.1' 'ovirt-engine-3.6.2' 'ovirt-engine-3.5' 'ovirt-engine-3.4' 'ovirt-engine-3.3' 'engine_3.2' 'engine_3.1' 'ovirt-engine-3.5.2' 'ovirt-engine-3.4.0' 'ovirt-engine-3.3.4' 'ovirt-engine-3.3.3' 'ovirt-engine-3.3.2' 'ovirt-engine-3.3.1')<br>
<br>
STABLE_BRANCHES="ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-engine-3.6.3 ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 ovirt-engine-3.5.2 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1"<br>
<br>
CHECK_TARGET_RELEASE=("ovirt-engine-3.6|^3\.[6543210].*" "ovirt-engine-3.5|^3\.[543210].*" "ovirt-engine-3.4|^3\.[43210].*" "ovirt-engine-3.3|^3\.[3210].*" "ovirt-engine-3.4.1|^3.4.1$")<br>
<br>
CHECK_TARGET_MILESTONE=('ovirt-engine-3.6.0|^.*3\.6\.0.*$' 'ovirt-engine-3.6|^.*3\.6.*' 'ovirt-engine-3.5|^.*3\.5.*' 'ovirt-engine-3.4|^.*3\.4.*' 'ovirt-engine-3.3|^.*3\.3.*' 'ovirt-engine-3.4.1|^.*3.4.1.*$')<br>
<br>
PRODUCT="oVirt<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> On Tue, Feb 2, 2016 at 5:19 PM, David Caro <<a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a>> wrote:<br>
><br>
> > On 01/28 16:17, Eyal Edri wrote:<br>
> > > David,<br>
> > > Is it something manual we need to change per version or we can add<br>
> > > something automatic to work on any 3.6.X branch only (exluding the 3.6<br>
> > > branch)?<br>
> ><br>
> > Can you summarize the complete checks that should be done on the hooks<br>
> > side? Because it's starting to be a bit of a mess as we are changing<br>
> > small things each time without the complete knowledge (for example,<br>
> > the target release was being checked before when moving to MODIFIED,<br>
> > and that was commented out, and there's a hook to warn if the patch is<br>
> > not merged yet on a previous branch, like not being merged on 3.6 if<br>
> > it's on 3.6.x)<br>
> ><br>
> ><br>
> ><br>
> > ><br>
> > > e.<br>
> > ><br>
> > > On Thu, Jan 28, 2016 at 4:00 PM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>> wrote:<br>
> > ><br>
> > > > This was the behavior in 3.6.2, don't know why it changed<br>
> > > ><br>
> > > > On Thu, Jan 28, 2016 at 3:57 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> > > ><br>
> > > >> so maybe we'll stop moving bugs to MODIFIED if they are merged on<br>
> > stable<br>
> > > >> branch (i.e ovirt-engine-3.6) and only if its merged into a version<br>
> > branch<br>
> > > >> (i.e ovirt-engine-3.6.3) ?<br>
> > > >><br>
> > > >> On Thu, Jan 28, 2016 at 3:52 PM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>> wrote:<br>
> > > >><br>
> > > >>> It makes life easier for everyone when automation moves the bug to<br>
> > > >>> MODIFIED, if the work is not done then the developer can always move<br>
> > it<br>
> > > >>> back to POST like we sometimes do.<br>
> > > >>> In any way, when a 3.6.3 bug is merged in 3.6.3 it should be moved to<br>
> > > >>> MODIFIED, not a second before<br>
> > > >>><br>
> > > >>><br>
> > > >>> On Thu, Jan 28, 2016 at 12:23 PM, Yedidyah Bar David <<br>
> > <a href="mailto:didi@redhat.com">didi@redhat.com</a>><br>
> > > >>> wrote:<br>
> > > >>><br>
> > > >>>> On Thu, Jan 28, 2016 at 10:59 AM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>><br>
> > wrote:<br>
> > > >>>> ><br>
> > > >>>> ><br>
> > > >>>> > On Thu, Jan 28, 2016 at 10:23 AM, Yedidyah Bar David <<br>
> > <a href="mailto:didi@redhat.com">didi@redhat.com</a><br>
> > > >>>> ><br>
> > > >>>> > wrote:<br>
> > > >>>> >><br>
> > > >>>> >> On Thu, Jan 28, 2016 at 10:08 AM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>><br>
> > > >>>> wrote:<br>
> > > >>>> >> > Maybe we should change the logic on moving bugs to MODIFIED,<br>
> > > >>>> >> > Now that we moved to the version branch.<br>
> > > >>>> >> ><br>
> > > >>>> >> > Tal - any thoughts on a logic that SHOULD move bugs to MODIFIED<br>
> > > >>>> that<br>
> > > >>>> >> > we'll<br>
> > > >>>> >> > be sure its OK?<br>
> > > >>>> >><br>
> > > >>>> >> Repeating myself from a previous discussion: I think we should<br>
> > never<br>
> > > >>>> move<br>
> > > >>>> >> bugs from POST to MODIFIED. Only a developer can know if it's<br>
> > indeed<br>
> > > >>>> >> ready,<br>
> > > >>>> >> or another patch is still needed but was not yet pushed. I think<br>
> > it's<br>
> > > >>>> >> safer<br>
> > > >>>> >> to miss bugs left on POST although they could have been moved to<br>
> > > >>>> MODIFIED,<br>
> > > >>>> >> than the opposite - move to MODIFIED bugs that actually require<br>
> > more<br>
> > > >>>> work.<br>
> > > >>>> >><br>
> > > >>>> ><br>
> > > >>>> > You're optimistic that bugs will not stay on POST, we've done it<br>
> > in<br>
> > > >>>> the<br>
> > > >>>> > past.<br>
> > > >>>> > This has a bigger risk of bugs getting left behind on POST and<br>
> > > >>>> increasing<br>
> > > >>>> > the amount of<br>
> > > >>>> > bugs that are not verified on time.<br>
> > > >>>> ><br>
> > > >>>> > Its the easiest solution to drop this bot, but i belive it will do<br>
> > > >>>> more<br>
> > > >>>> > damage than good.<br>
> > > >>>><br>
> > > >>>> Perhaps, then, run it once a day and move to MODIFIED only if last<br>
> > patch<br>
> > > >>>> was merged at least X hours ago? Hopefully developers will not wait<br>
> > more<br>
> > > >>>> than X before pushing an additional patch for the same bug if<br>
> > needed.<br>
> > > >>>><br>
> > > >>>> Of course, we then also have to fix the issue starting current<br>
> > thread.<br>
> > > >>>><br>
> > > >>>> ><br>
> > > >>>> >><br>
> > > >>>> >> ><br>
> > > >>>> >> > e.<br>
> > > >>>> >> ><br>
> > > >>>> >> > On Thu, Jan 28, 2016 at 10:03 AM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a><br>
> > ><br>
> > > >>>> wrote:<br>
> > > >>>> >> >><br>
> > > >>>> >> >> After merging a patch for a 3.6.3 bug on the ovirt-engine-3.6<br>
> > > >>>> branch<br>
> > > >>>> >> >> the<br>
> > > >>>> >> >> bug is moved to MODIFIED, since the 3.6.3 branch was opened<br>
> > > >>>> yesterday<br>
> > > >>>> >> >> the<br>
> > > >>>> >> >> bug should stay in POST until merged in ovirt-engine-3.6.3<br>
> > branch<br>
> > > >>>> as<br>
> > > >>>> >> >> well<br>
> > > >>>> >> >><br>
> > > >>>> >> >><br>
> > > >>>> >> >> _______________________________________________<br>
> > > >>>> >> >> Infra mailing list<br>
> > > >>>> >> >> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> > > >>>> >> >> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
> > > >>>> >> >><br>
> > > >>>> >> ><br>
> > > >>>> >> ><br>
> > > >>>> >> ><br>
> > > >>>> >> > --<br>
> > > >>>> >> > Eyal Edri<br>
> > > >>>> >> > Associate Manager<br>
> > > >>>> >> > EMEA ENG Virtualization R&D<br>
> > > >>>> >> > Red Hat Israel<br>
> > > >>>> >> ><br>
> > > >>>> >> > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > > >>>> >> > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> > > >>>> >> ><br>
> > > >>>> >> > _______________________________________________<br>
> > > >>>> >> > Infra mailing list<br>
> > > >>>> >> > <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> > > >>>> >> > <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
> > > >>>> >> ><br>
> > > >>>> >><br>
> > > >>>> >><br>
> > > >>>> >><br>
> > > >>>> >> --<br>
> > > >>>> >> Didi<br>
> > > >>>> ><br>
> > > >>>> ><br>
> > > >>>> ><br>
> > > >>>> ><br>
> > > >>>> > --<br>
> > > >>>> > Eyal Edri<br>
> > > >>>> > Associate Manager<br>
> > > >>>> > EMEA ENG Virtualization R&D<br>
> > > >>>> > Red Hat Israel<br>
> > > >>>> ><br>
> > > >>>> > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > > >>>> > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> > > >>>><br>
> > > >>>><br>
> > > >>>><br>
> > > >>>> --<br>
> > > >>>> Didi<br>
> > > >>>><br>
> > > >>><br>
> > > >>><br>
> > > >><br>
> > > >><br>
> > > >> --<br>
> > > >> Eyal Edri<br>
> > > >> Associate Manager<br>
> > > >> EMEA ENG Virtualization R&D<br>
> > > >> Red Hat Israel<br>
> > > >><br>
> > > >> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > > >> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> > > >><br>
> > > ><br>
> > > ><br>
> > ><br>
> > ><br>
> > > --<br>
> > > Eyal Edri<br>
> > > Associate Manager<br>
> > > EMEA ENG Virtualization R&D<br>
> > > Red Hat Israel<br>
> > ><br>
> > > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> ><br>
> > --<br>
> > David Caro<br>
> ><br>
> > Red Hat S.L.<br>
> > Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
> ><br>
> > Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
> > Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
> > IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
> > Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
> > RHT Global #: 82-62605<br>
> ><br>
><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
<br>
--<br>
David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Eyal Edri<br>Associate Manager<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div>
</div>