<div dir="ltr"><table style="font-size:12.8px;width:778px;color:rgb(53,53,53);font-family:sans-serif"><tbody><tr><td title="Juan Hernandez <juan.hernandez@redhat.com>">About <a href="https://gerrit.ovirt.org/#/c/46925/">https://gerrit.ovirt.org/#/c/46925/</a><br><br><br><font face="sans-serif"><span style="white-space:nowrap"><b>Juan Hernandez</b></span></font></td><td style="font-family:sans-serif;width:570px"></td><td align="right" title="Mar 7, 2016 5:34 PM" style="font-family:sans-serif;white-space:nowrap">Mar 7 5:34 PM</td></tr></tbody></table><div style="font-size:12.8px;padding-bottom:1px;color:rgb(53,53,53);font-family:sans-serif"><div style="padding-left:0.5em;padding-right:0.5em"><p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em">Patch Set 14:</p><p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em">The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and this patch doesn't use it. Will we preserve the separate findbugs job?</p><p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em">In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.</p></div></div><div><br></div><div><br></div><div>Eyal, David, other infra members, any hint on how to progress with this patch?</div><div><br></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div>