<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Merged a patch to the build itself to run it [1] - no need to mess around with an additional script for this, it should just be a part of the maven build.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">[1] <a href="https://gerrit.ovirt.org/#/c/54997/">https://gerrit.ovirt.org/#/c/54997/</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 21, 2016 at 10:45 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I agree, this is one of the advantages of the standard CI [1].<div>You can update 'check-patch.sh' or 'check-merged' with the maven command you'd like to add via a commit to gerrit, and we can help with the review.</div><div><br></div><div>I think the best way will be to add it either as a new Make goal (like validations) and then add a line to the check-patch.sh to run the goal,<br></div><div>You can also add a new maven profile for animal sniffer so just running mvn test -Panimal will do the trick.</div><div><br></div><div>I think Juan sent already something for it..</div><div><br></div><div><br></div><div>[1] <a href="http://ovirt-infra-docs.readthedocs.org/en/latest/CI/Build_and_test_standards.html" target="_blank">http://ovirt-infra-docs.readthedocs.org/en/latest/CI/Build_and_test_standards.html</a></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Mon, Mar 21, 2016 at 6:27 AM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><span>> TL;DR - we need this job re-enabled:<br>
><br>
> What to run - "mvn animal-sniffer:check" on a directory that already has the<br>
> built targets. If you're triggering it on sources that haven't been built<br>
> yet, or on a directory you're not sure about the status, use "mvn clean<br>
> install animal-sniffer:check -DskipTests" instead<br>
> When to run - trigger per verified patch in gerrit (similar to findbugs) on<br>
> a patch that touches one of the following directories:<br>
><br>
> backend/manager/modules/compat<br>
> backend/manager/modules/common<br>
> backend/manager/modules/searchbackend<br>
> backend/manager/modules/aaa<br>
><br>
<br>
</span>This can be easily added to check_patch.sh in the engine repo, you<br>
don't need us (infra) to enable this at all.<br>
</div></div><span><font color="#888888"><div><div class="h5"><br>
--<br>
Barak Korren<br>
<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a><br>
RHEV-CI Team<br></div></div>
_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</font></span></div>
</blockquote></div><br></div>