<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 30, 2016 at 11:56 AM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 03/30 11:45, Roy Golan wrote:<br>
> Hi all,<br>
><br>
> Eyal and I sat together to analyse and tweak the engine CI and this is what<br>
> we came up with:<br>
><br>
> - dao test excludes updated - exclude dal/src/main/bundles from invoking<br>
> dao tests<br>
> A trivial update of validation messages without any db change would<br>
> trigger dao test without any need. This is one less job run for lots of<br>
> patches.<br>
> This change is effective now.<br>
<br>
</span>I really recommend merging this into the standard ci scripts and doing the<br>
trigger/don't trigger stuff there<br></blockquote><div><br></div><div>Yea, thats the plan (discussed on another thread) but since it requires some logic added of excluding certain path</div><div>we'll need to think how best to write it in check-patch.sh.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
><br>
> - Spare CI re-run on trivial rebases<br>
> Gerrit trigger supports suppressing itself if the change to the tree was<br>
> trivial. Most of the waste of resources(time and IO :) ) is around<br>
> rebasing a change and waiting for CI to rerun. if Change1 is ci+1 and<br>
> Change2 is ci+1 the chances that they will break CI together is very small<br>
> and taking that risk is most probably worth it due to the huge resources<br>
> waste<br>
<br>
</span>This is not exactly how it works, trivial rebases don't care if the previous<br>
patch had ci+1 or not, it just means that the rebase did not get any conflicts,<br>
that most of the time is not related to the tests working or not (it might be<br>
that someone change a method on another file, that your patch is using and it<br>
will be a trivial rebase and break the tests/compile). <br></blockquote><div><br></div><div>Even so, I think its worth doing a test for a limited amount of time (1 week?) </div><div>while everyone is aware of it and to see if it cause errors, the chances </div><div>of 2 people working on the same file exactly during the same time and one change failing another</div><div>is slim (If someone thinks otherwise and can give an example I'd be happy to hear),</div><div>But since this is a gray area which we don't really know, I think its worth the test.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I don't really recommend skipping them. What you might meant is non-code<br>
changes, those are changes that only change the commit message, for example, if<br>
you have a patch, and you want to fix a typo in the commit message, currently<br>
that small commit message fix will require and trigger a ci run, while when<br>
skipping the non-code changes, it will not needed.<br>
<span class=""><br>
> This change isn't effective yet - *Please reply here* if you agree or not<br>
> to make this change available.<br>
><br>
> All of this is 'master' - 3.6 will follow if we will agree on activating<br>
> that change.<br>
><br>
> Thanks,<br>
> Roy<br>
<br>
</span>> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</font></span><br>_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div>