<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 12, 2016 at 11:42 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">You can see that the hooks is running on that branch it just ignores validation cause it doesn't see it as a stable branch<br><br></div></blockquote><div><br></div><div>Can you show example where validation was ignored?</div><div>FYI, We removed some of the old jobs that were running per patch as their code is part of the code in check-patch.sh already,</div><div>maybe that's what you refer to? </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">While we're at at it, where can I find the hooks repo? I'd like to write that will check properly for problems in the DB upgrade scripts</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 12, 2016 at 11:37 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I also checked the VDSM hooks config, <div>and I think we're missing there validation on target milestone/release, but wasn't sure what to update (lets wait for David to reply).</div><div><br></div><div><span><div>## Branches to take into account<br></div></span><div>BRANCHES=('ovirt-3.6')</div><div>STABLE_BRANCHES="ovirt-3.6"<br></div><div>CHECK_TARGET_RELEASE=("ovirt-3.5|^3\.[54321].*")<br></div><div>CHECK_TARGET_MILESTONE=('ovirt-3.6|^.*3\.6.*')<br></div><div><br></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 12, 2016 at 11:31 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I did some cleanups on the config files and now it only shows the relevant versions (which includes 3.6.5).<div><br></div><div><div>## Branches to take into account</div><div>BRANCHES=('ovirt-engine-3.6' 'ovirt-engine-3.6.0' 'ovirt-engine-3.6.1' 'ovirt-engine-3.6.2')</div><div> </div><div>STABLE_BRANCHES="ovirt-engine-3.6 ovirt-engine-3.6.5"</div><div> </div><div>CHECK_TARGET_RELEASE=("ovirt-engine-3.6|^3\.[6543210].*") </div><div> </div><div>CHECK_TARGET_MILESTONE=('ovirt-engine-3.6|^.*3\.6.*') </div><div> </div><div>PRODUCT="oVirt"</div></div><div><br></div><div>I also see on the patch the jobs run:</div><div><div style="padding-left:5px;padding-right:5px"><div><div style="margin-bottom:1em"><div style="width:1168px;padding:2px 0px;border-left-width:1px;border-left-style:solid;border-left-color:rgb(227,233,255);border-right-width:1px;border-right-style:solid;border-right-color:rgb(227,233,255);border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:rgb(227,233,255);border-bottom-left-radius:8px;border-bottom-right-radius:8px"><div style="margin-left:28px"><div style="overflow:auto"><div><p style="white-space:pre-wrap">Build Successful </p><p style="white-space:pre-wrap"><a href="http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el7-x86_64/35/" style="color:rgb(6,84,172);text-decoration:none" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el7-x86_64/35/</a> : SUCCESS</p><p style="white-space:pre-wrap"><a href="http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-fc23-x86_64/36/" style="color:rgb(6,84,172);text-decoration:none" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-fc23-x86_64/36/</a> : SUCCESS</p><p style="white-space:pre-wrap"><a href="http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el6-x86_64/36/" style="color:rgb(6,84,172);text-decoration:none" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el6-x86_64/36/</a> : SUCCESS</p></div></div></div></div></div></div></div><div style="clear:both"><div style="color:rgb(53,53,53);font-family:sans-serif"></div></div></div><div><br></div><div>So what is missing?</div><div><br></div><div>BTW, David - can we use regex in the stable branch names? I think we can enable any 3.6.z branch.</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Mon, Apr 11, 2016 at 3:45 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Quite sure we handled this issue but it seems that it's not treated as monitored still:<div>(Taken from <a href="https://gerrit.ovirt.org/#/c/55938" target="_blank">https://gerrit.ovirt.org/#/c/55938</a>)</div><div><ul style="color:rgb(53,53,53);font-family:sans-serif"><li>Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.5.2 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)</li></ul></div></div>
<br></div></div>_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div>