<div dir="ltr">You can see that Jenkins gave +1 in patchset 2 (which is identical to patchset 4 aside for the commit message, you can also see that those jobs started:<div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (1/2) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/598/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/598/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (2/2) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/598/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/598/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started -> </span><a href="http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/15450/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/15450/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (1/4) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/140/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/140/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (2/4) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-fc23-x86_64/140/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-fc23-x86_64/140/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (3/4) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/146/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/146/</a><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap">Build Started (4/4) -> </span><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged/141/" target="_blank" style="color:rgb(6,84,172);text-decoration:none;font-family:sans-serif;white-space:pre-wrap">http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged/141/</a><br></div><div><br></div><div>No findbugs job, if it did start there was no indication within the patch so the owner could not know he introduced a findbugs error.</div><div><br></div><div>As for the DAO tests, I get it, a change in the common module triggers that as well, thanks.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 9, 2016 at 4:32 PM, Shlomo Ben David <span dir="ltr"><<a href="mailto:sbendavi@redhat.com" target="_blank">sbendavi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Nisan,<div><br></div><div>1. The findbugs job run at May 5 1:50 PM and returned with the following msg: 'The patch does not pass the findbugs'</div><div>2. The resource consuming DAO test run because there was a change in the following file in the patch: backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java</div><div>It's configured in Jenkins gerrit filters as a trigger.</div><div class="gmail_extra"><br clear="all"><div><div><div dir="ltr"><div><div>Best Regards,</div><div dir="ltr"><br></div><div dir="ltr"><span class="">Shlomi Ben-David | Software Engineer | Red Hat ISRAEL<br></span><span class="">IRC: sbendavi<br><br>OPEN SOURCE - 1 4 011 && 011 4 1<br></span></div></div></div></div></div>
<br><div class="gmail_quote"><span class="">On Sun, May 8, 2016 at 10:34 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Upon looking at another patch I saw that there's a new findbugs issue:<div><a href="http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/" target="_blank">http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/</a><br></div><div><br></div><div>I've fixed the issue in this patch - <a href="https://gerrit.ovirt.org/57209" target="_blank">https://gerrit.ovirt.org/57209</a> so it's all good now but I'm wondering why the findbugs job did not run in the first place.</div><div>You can see that in the patch that introduced the issue - <a href="https://gerrit.ovirt.org/#/c/57054/" target="_blank">https://gerrit.ovirt.org/#/c/57054/</a></div><div>Also, why did the resource consuming DAO test ran although there were no changes in the dal module?</div><div><br></div></div>
<br></div></div><span class="">_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br></span></blockquote></div><br></div></div>
</blockquote></div><br></div>