<div dir="ltr">Oh I see now what you are talking about, indeed in patchset 20 jobs were marked as successful even though the actually failed, a bug indeed</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 5:33 PM, Martin Perina <span dir="ltr">&lt;<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Thu, May 19, 2016 at 4:26 PM, Tal Nisan <span dir="ltr">&lt;<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No need, already reverted once I&#39;ve read you message, had it reverted and verified so I could keep working on the branch - <a href="https://gerrit.ovirt.org/#/c/57742/" target="_blank">https://gerrit.ovirt.org/#/c/57742/</a><div>BTW, both jobs ended with a failure:</div><div><p style="white-space:pre-wrap;color:rgb(53,53,53);font-family:sans-serif"><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/310/" style="color:rgb(6,84,172);text-decoration:none" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/310/</a> : FAILURE</p><p style="white-space:pre-wrap;color:rgb(53,53,53);font-family:sans-serif"><a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged/307/" style="color:rgb(6,84,172);text-decoration:none" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged/307/</a> : FAILURE</p></div></div></blockquote></span><div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​Yes, but those are executed only after patch is merged​, check-patch jobs are return SUCCESS if when build failed, David is working on that.<br><br></div></div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><p style="white-space:pre-wrap;color:rgb(53,53,53);font-family:sans-serif"><br></p></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 5:22 PM, David Caro <span dir="ltr">&lt;<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 05/19 16:20, Martin Perina wrote:<br>
&gt; On Thu, May 19, 2016 at 4:15 PM, David Caro &lt;<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>&gt; wrote:<br>
&gt;<br>
&gt; &gt; On 05/19 16:14, Martin Perina wrote:<br>
&gt; &gt; &gt; Hi,<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; so I probably found the issue why this broke the build. I have checked<br>
&gt; &gt; the<br>
&gt; &gt; &gt; CI before merging and it was OK,<br>
&gt; &gt; &gt; see CI+1 on patch set 20.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Now looking at console outputs of those jobs, the build itself failed,<br>
&gt; &gt; but<br>
&gt; &gt; &gt; build jobs are marked as SUCCESSFULL.<br>
&gt; &gt; &gt; So it seems we have a bug in those jobs!!!<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; We will need a bit more info on which project/jenkins job/build, etc, by<br>
&gt; &gt; the<br>
&gt; &gt; email  I can&#39;t extract the project that failed<br>
&gt; &gt;<br>
&gt;<br>
&gt; ​Sorry, here is the problematic patch: <a href="https://gerrit.ovirt.org/#/c/57052/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/57052/</a><br>
&gt;<br>
&gt; The problematic patch is build on patch set 20. It&#39;s marked as successfull,<br>
&gt; although engine build failed:<br>
&gt;<br>
&gt; <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250/console</a><br>
&gt;<br>
&gt;<br>
&gt; Anyway, we are preparing reverting patch ...<br>
<br>
<br>
</span>I see, the issue was introduced by me in the mock_runner.sh script, will send a<br>
patch right away<br>
<div><div><br>
&gt;<br>
&gt; Sorry for the issue.<br>
&gt;<br>
&gt; Martin<br>
&gt; ​<br>
&gt;<br>
&gt;<br>
&gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; On Thu, May 19, 2016 at 3:53 PM, Tal Nisan &lt;<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>&gt; wrote:<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; This commit broke the build, missing KernelEnv.<br>
&gt; &gt; &gt; &gt; Normally I&#39;d revert but since it&#39;s feature freeze I&#39;m more forgiving :)<br>
&gt; &gt; &gt; &gt; Please either revert or send a fix asap.<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Thanks.<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; &gt; _______________________________________________<br>
&gt; &gt; &gt; Infra mailing list<br>
&gt; &gt; &gt; <a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
&gt; &gt; &gt; <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; --<br>
&gt; &gt; David Caro<br>
&gt; &gt;<br>
&gt; &gt; Red Hat S.L.<br>
&gt; &gt; Continuous Integration Engineer - EMEA ENG Virtualization R&amp;D<br>
&gt; &gt;<br>
&gt; &gt; Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605" target="_blank">+420 532 294 605</a><br>
&gt; &gt; Email: <a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a><br>
&gt; &gt; IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
&gt; &gt; Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
&gt; &gt; RHT Global #: 82-62605<br>
&gt; &gt;<span><font color="#888888"><br>
<br>
--<br>
David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&amp;D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605" target="_blank">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</font></span></div></div></blockquote></div><br></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>