<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 25, 2016 at 5:43 PM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 05/25 16:03, Tal Nisan wrote:<br>
> On Wed, May 25, 2016 at 4:00 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
><br>
> ><br>
> ><br>
> > On Wed, May 25, 2016 at 3:43 PM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>> wrote:<br>
> ><br>
> >><br>
> >><br>
> >> On Wed, May 25, 2016 at 3:37 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> >><br>
> >>><br>
> >>><br>
> >>> On Wed, May 25, 2016 at 3:33 PM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>> wrote:<br>
> >>><br>
> >>>><br>
> >>>><br>
> >>>> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> >>>><br>
> >>>>> db upgrade jobs should be covered by engine-setup/upgrade so I don't<br>
> >>>>> see a reason to keep running them.<br>
> >>>>><br>
> >>>> You mean the checkpatch jobs cover them? Cause upgrade scripts changes<br>
> >>>> need to be tested as well<br>
> >>>><br>
> >>><br>
> >>> 2 things IMO cover this:<br>
> >>> 1. the db duplicate script in check-patch.sh<br>
> >>> 2. ovirt-engine setup/upgrade not in standard ci (since we can't run<br>
> >>> setup on mock)<br>
> >>><br>
> >>> If this is not the case, we need to migrate the db scripts to<br>
> >>> check-patch.<br>
> >>><br>
> >> Unless I got it all wrong I recall we had an upgrade script check on the<br>
> >> old master, it seems like it's still running:<br>
> >><br>
> >> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/</a><br>
> >><br>
> >><br>
> >><br>
> > That is not db upgrade, its the setup job I talked about and I think<br>
> > sandro added it to 4.0 already.<br>
> ><br>
> It didn't run on the patch I sent as an example<br>
<br>
<br>
</span>It only runs on merges<br></blockquote><div>OK, that clarifies, thanks </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">><br>
> ><br>
> ><br>
> ><br>
> >><br>
> >>><br>
> >>>><br>
> >>>>> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> >>>>><br>
> >>>>>> Dao tests are run in the old jenkins still (pending migrate to<br>
> >>>>>> standard ci - we'll appreciate help from DEV migrating it).<br>
> >>>>>> Right now i'm cloning the jobs to run on 4.0 on old-jenkins.<br>
> >>>>>><br>
> >>>>> What's needed for that migration?<br>
> >>>><br>
> >>><br>
> >>> Just to copy the code to a bash script and test it, i started a very<br>
> >>> draft and ugly code here:<br>
> >>><br>
> >>> <a href="https://gerrit.ovirt.org/#/c/55808/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/55808/</a><br>
> >>><br>
> >> Unfortunately we don't have the resources currently to help in that<br>
> >> front, maybe other teams can help?<br>
> >> Why not copy the existing behavior from old Jenkins though?<br>
> >><br>
> ><br>
> > We can't since they require local changes to the VMs which are not enabled<br>
> > on new slaves in new jenkins.<br>
> > For e.g - dao tests needs postgresql installed and configured - which we<br>
> > can't enable on the new jenkins without breaking other stuff.<br>
> ><br>
> > The best solution will be to migrate this job to standard CI - so we need<br>
> > a dev to sit with CI engineer - its also more complicated since we moved to<br>
> > el7 and new postgres.<br>
> ><br>
> OK, guess that for now I'll either test DAO myself or make a system based<br>
> on trust :)<br>
><br>
> ><br>
> ><br>
> ><br>
> >><br>
> >>><br>
> >>><br>
> >>><br>
> >>>><br>
> >>>>>><br>
> >>>>>><br>
> >>>>>> On Wed, May 25, 2016 at 3:11 PM, Tal Nisan <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>> wrote:<br>
> >>>>>><br>
> >>>>>>> Encountered that in this patch:<br>
> >>>>>>> <a href="https://gerrit.ovirt.org/#/c/58034/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/58034/</a><br>
> >>>>>>><br>
> >>>>>>> It introduces both an upgrade script change and a change in the DAO<br>
> >>>>>>> layer yet it seems that DAO tests and upgrade test did not run<br>
> >>>>>>><br>
> >>>>>>><br>
> >>>>>>> _______________________________________________<br>
> >>>>>>> Infra mailing list<br>
> >>>>>>> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> >>>>>>> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
> >>>>>>><br>
> >>>>>>><br>
> >>>>>><br>
> >>>>>><br>
> >>>>>> --<br>
> >>>>>> Eyal Edri<br>
> >>>>>> Associate Manager<br>
> >>>>>> RHEV DevOps<br>
> >>>>>> EMEA ENG Virtualization R&D<br>
> >>>>>> Red Hat Israel<br>
> >>>>>><br>
> >>>>>> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> >>>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> >>>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> --<br>
> >>>>> Eyal Edri<br>
> >>>>> Associate Manager<br>
> >>>>> RHEV DevOps<br>
> >>>>> EMEA ENG Virtualization R&D<br>
> >>>>> Red Hat Israel<br>
> >>>>><br>
> >>>>> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> >>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> >>>>><br>
> >>>><br>
> >>>><br>
> >>><br>
> >>><br>
> >>> --<br>
> >>> Eyal Edri<br>
> >>> Associate Manager<br>
> >>> RHEV DevOps<br>
> >>> EMEA ENG Virtualization R&D<br>
> >>> Red Hat Israel<br>
> >>><br>
> >>> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> >>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> >>><br>
> >><br>
> >><br>
> ><br>
> ><br>
> > --<br>
> > Eyal Edri<br>
> > Associate Manager<br>
> > RHEV DevOps<br>
> > EMEA ENG Virtualization R&D<br>
> > Red Hat Israel<br>
> ><br>
> > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> ><br>
<br>
> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br>
<br>
--<br>
</div></div>David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</blockquote></div><br></div></div>