<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 30, 2016 at 9:35 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">both check-patch and check-merge are using the following rpmbuild params:<div><br><div><div>rpmbuild \</div><div> -D "_rpmdir $PWD/output" \</div><div> -D "_topmdir $PWD/rpmbuild" \</div><div> -D "release_suffix ${SUFFIX}" \</div><div> -D "ovirt_build_ut $BUILD_UT" \</div><div> -D "ovirt_build_extra_flags $EXTRA_BUILD_FLAGS" \</div><div> -D "ovirt_build_quick 1" \</div><div> --rebuild output/*.src.rpm</div></div><div><br></div><div><br></div><div>I think the -D "ovirt_build_quick 1" skips GWT compilation or at least some of the permutations, so if the errors was related to GWT it explains the problem. </div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>I suggest to change check-merge to include the basic GWT compilation with a single permutation so we'll catch these at least after merge (if its doesn't take too long, worth considering adding to </div><div>check-patch.sh).</div></div></div></blockquote><div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Yes, ovirt_build_quick skips GWT compilation completely, we should use ovirt_build_minimal which compiles GWT for English and Firefox only.<br></div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div>This requires a patch to ovirt-engine automation/check-merge.sh file on master, ovirt-engine-4.0 and ovirt-engine-3.6.</div></div></div></blockquote><div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Here's the patch for master:<br><br><a href="https://gerrit.ovirt.org/58246">https://gerrit.ovirt.org/58246</a><br></div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 30, 2016 at 10:25 AM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, May 30, 2016 at 9:05 AM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 30 May 2016 at 09:51, Martin Perina <<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>> wrote:<br>
> Hi,<br>
><br>
> I just verified that local build is is broken by the same error in<br>
> HostedEngineDeployConfiguration.<br>
> I will post a fix for that, but upgrade-job build is correct (raised build<br>
> failure) and check-merged jobs<br>
> are broken (producing success although build is broken), could you please<br>
> fix them asap?.<br>
><br>
<br>
Since those are std-CI jobs, I've no clue what they do and how to fix<br>
them, and also no permissions to do so (I'm not an engine maintainer).<br>
Everything they do is in the automation dir.<br>
<br>
You can try to run them locally as well, see [1]<br>
<br>
[1]: <a href="http://ovirt-infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standards.html#testing-the-scripts-locally" rel="noreferrer" target="_blank">http://ovirt-infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standards.html#testing-the-scripts-locally</a><br>
<br>
It is an interesting problem though, what could make the build succeed<br>
inside mock but fail otherwise?<br></blockquote></span><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline">There's no way how those builds could be successful regardless of using mock, GWT build had always to fail without patch [2], so the issue is somewhere inside CI/Jenkins/mock magic.<br></div><div style="font-family:arial,helvetica,sans-serif;display:inline"><br>I'm sorry, but I need today to focus in finishing patch for 3.6.7 bug, so I don't have time to investigate the issue, but IMO it needs to be resolved ASAP, otherwise<br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">more broken patches can be merged.<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">@Eyal, is there somebody in CI team who can investigate this (assuming CI team members have much better knowledge of CI/Jenkins/mock magic</div><div style="font-family:arial,helvetica,sans-serif;display:inline"> and standard engine build command raised error correctly)?<br></div><div style="font-family:arial,helvetica,sans-serif;display:inline"><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Thanks<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Martin<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">[2] <a href="https://gerrit.ovirt.org/58242" target="_blank">https://gerrit.ovirt.org/58242</a><br><br></div></div><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
The loges here seem to do the same things:<br>
<a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/419/artifact/exported-artifacts/logs.tgz" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/419/artifact/exported-artifacts/logs.tgz</a><br>
(See the check_merged.sh log)<span class=""><font color="#888888"><br>
<span><font color="#888888"><br>
--<br>
Barak Korren<br>
<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a><br>
RHEV-CI Team<br>
</font></span></font></span></blockquote></span></div><span class=""><font color="#888888"><br></font></span></div></div><span class=""><font color="#888888">
</font></span></blockquote></div><span class=""><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</font></span></div>
</blockquote></div><br></div></div>