<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Martin Perina" <mperina@redhat.com><br><b>To: </b>"Eli Mesika" <emesika@redhat.com><br><b>Cc: </b>"Eyal Edri" <eedri@redhat.com>, "infra" <infra@ovirt.org><br><b>Sent: </b>Tuesday, June 7, 2016 11:45:28 AM<br><b>Subject: </b>Re: Duplicate upgrade scripts issue<br><div><br></div><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 11:42 AM, Eli Mesika <span dir="ltr"><<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div style="font-size:large">Ha , one more thing :<br><div><br></div></div><div style="font-size:large">We would like to force the existence of such hooks if possible ...<br></div></div></blockquote><div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">+1<br><div><br></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">The hook should be included by default after git clone if possible. And if it's then I'd also force inclusion of commit message hook which generates change-id</div></div></div></div></div></blockquote><div><br></div><div><br>Git does not allow 'autodownloading' hooks, you can't distribute them by git clone, the client must explicitly install them herself<br></div><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br><div><br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 12:41 PM, Eli Mesika <span dir="ltr"><<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div style="font-size:large">Hi guys <br><div><br></div></div><div style="font-size:large">I have talked with Eyal about the $Subject and he asked me to write and send this email <br><div><br></div></div><div style="font-size:large">As you probably know, we have from time to time an issue with duplicate upgrade scripts that are merged by mistake, each such issue forces us to publish a fixing patch that renames the duplicated file.<br></div><div style="font-size:large">I was discussed this issue today with Marin P on out weekly meeting <br><div><br></div></div><div style="font-size:large">We would like to write some kind of a hook that will check on each patch set if it has DB upgrade files and rename them (if necessary) such that it will have the correct numbering according to the last existing upgrade patch on the related branch.<br><div><br></div></div><div style="font-size:large">The hook should be done upon 'git push' request so it will also prevent CI tests to fail on this issue <br></div><div style="font-size:large"><br></div><div style="font-size:large">I will be happy to get your ideas/comments on that <br><div><br></div></div><div style="font-size:large">Thanks <br><span><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><br></span></span></div><span><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><div style="font-size:large">Eli Mesika <br></div></span></span></div></blockquote></div><br></div></blockquote></div><br></div></div><br>_______________________________________________<br>Infra mailing list<br>Infra@ovirt.org<br>http://lists.ovirt.org/mailman/listinfo/infra<br></blockquote><div><br></div></div></body></html>