<div dir="ltr">So I'm not sure its a false positive, it was real issue at that time and a rebase was needed to fix it.<div>What we do need to investigate is why juan's patch wasn't given -1 before merge, juan - can you check what did the findbugs job say on your patch?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 8, 2016 at 11:08 AM, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 07/08/2016 09:29 AM, Eyal Edri wrote:<br>
> I marked this build as keep forever so we can debug it.<br>
> Also, we are in the process of moving to a new findbugs jobs which are<br>
> written in Yaml and have a few small fixes,<br>
> so i've disabled the old job in favor<br>
> of <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created_test/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created_test/</a>.<br>
><br>
> @snaftaly from my team is working on it and will be able to debug it<br>
> next week.<br>
><br>
> My suspicison is that your patch was rebased at some point on another<br>
> patch with this failure which came from patch [1].<br>
> Juan - did you see at any point findbugs error on your patch and fixed it?<br>
><br>
> [1] <a href="https://gerrit.ovirt.org/#/c/59828/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/59828/</a><br>
><br>
<br>
</span>Eyal, that findbugs failure was introduced by a patch of mine, and then<br>
it was resolved by patch [1]. Patch [1] is already merged, but Martin's<br>
patch isn't rebased on top of it.<br>
<br>
Martin, rebase your patch and the issue will disappear.<br>
<span class=""><br>
> On Thu, Jul 7, 2016 at 10:22 PM, Martin Mucha (oVirt JIRA)<br>
</span>> <<a href="mailto:jira@ovirt-jira.atlassian.net">jira@ovirt-jira.atlassian.net</a> <mailto:<a href="mailto:jira@ovirt-jira.atlassian.net">jira@ovirt-jira.atlassian.net</a>>><br>
<span class="">> wrote:<br>
><br>
> Martin Mucha created OVIRT-624:<br>
> ----------------------------------<br>
><br>
> Summary: another invalid CI-1<br>
> Key: OVIRT-624<br>
> URL: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-624" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.net/browse/OVIRT-624</a><br>
> Project: oVirt - virtualization made easy<br>
> Issue Type: By-EMAIL<br>
> Reporter: Martin Mucha<br>
> Assignee: infra<br>
><br>
><br>
> Hi,<br>
><br>
> this build gave invalid ci -1:<br>
> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/46153/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/46153/</a><br>
><br>
> findbugs complaint about class not altered in patch.<br>
><br>
> please react quickly, before build disappears.<br>
> Thanks,<br>
> M.<br>
><br>
><br>
><br>
> --<br>
> This message was sent by Atlassian JIRA<br>
> (v1000.133.0#100004)<br>
> _______________________________________________<br>
> Infra mailing list<br>
</span>> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a> <mailto:<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a>><br>
<span class="">> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> RHEV DevOps<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
><br>
><br>
> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
><br>
<br>
<br>
--<br>
</span>Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
3ºD, 28016 Madrid, Spain<br>
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div>