<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 19 Jul 2016, at 14:25, Eyal Edri <<a href="mailto:eedri@redhat.com" class="">eedri@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Tue, Jul 19, 2016 at 1:37 PM, Michal Skrivanek<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:mskrivan@redhat.com" target="_blank" class="">mskrivan@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On 19 Jul 2016, at 12:15, Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank" class="">eedri@redhat.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">This happened because you used the same bug for master and 4.0.</div></div></blockquote><div class=""><br class=""></div></span>right, but that’s the regular state of things because upstream there is no separate bug for master vs current version</div><div class=""><span class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">The Gerrit hook doesn't verify status between major versions, only inside a single version (for e.g, it would not move to modified if you needed to backport to 4.0.1 and the target milestone was 4.0.1).</div><div class="">I'm not sure how we can tackle this, because master has no meaning in bugzilla, it doesn't correlate to a version.</div><div class=""><br class=""></div><div class="">One think I can think of, is NOT to move bugs to MODIFIED is a patch was merged on master branch... , will that help? </div></div></div></blockquote><div class=""><br class=""></div></span>I’m not sure if it’s better because before 4.1 is branched the master development is for 4.1 bugs.</div><div class="">It would make sense to differentiate based on whether a branch for that TM version exists or not, so in your above example since the bug has TM 4.0.x and there is a 4.0 branch it would wait for a backport</div></div></blockquote><div class=""><br class=""></div><div class="">I can't compare it to 4.0 because master is a moving target, so this hook will misbehave once master change versions, I need a solid logic that will work all the time for bugs on master.</div><div class="">either not move them to MODIFIED if the bug is on target milestone != master (which is probably 100% of the times) or some regex we can use... I don't have any other creative ideas…</div></div></div></blockquote><div><br class=""></div>I guess if we have TM as x.y.z and the projects have x.y branch we can check for that, right? if the branch is not there then master is the final branch; if TM x.y.z matches some ovirt-x.y branch the backport is needed.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">You can look at the code if you want at [1] and see if you have an idea.</div><div class=""><br class=""></div><div class="">[1] <a href="https://gerrit.ovirt.org/gitweb?p=gerrit-admin.git;a=blob;f=hooks/custom_hooks/change-merged.set_MODIFIED;h=678806dc35a372dadab5a5a392d25409db5c8275;hb=refs/heads/master" class="">https://gerrit.ovirt.org/gitweb?p=gerrit-admin.git;a=blob;f=hooks/custom_hooks/change-merged.set_MODIFIED;h=678806dc35a372dadab5a5a392d25409db5c8275;hb=refs/heads/master</a></div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">michal</div><span class=""><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jul 19, 2016 at 8:07 AM, Michal Skrivanek<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:mskrivan@redhat.com" target="_blank" class="">mskrivan@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">Example in bug<span class="Apple-converted-space"> </span><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1357440" rel="noreferrer" target="_blank" class="">https://bugzilla.redhat.com/show_bug.cgi?id=1357440</a><br class="">It doesn't take into account branches<br class=""><br class="">Thanks,<br class="">michal<br class=""></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div data-smartmail="gmail_signature" class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">Eyal Edri<br class="">Associate Manager</div><div class="">RHEV DevOps<br class="">EMEA ENG Virtualization R&D<br class="">Red Hat Israel<br class=""><br class="">phone:<span class="Apple-converted-space"> </span><a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank" class="">+972-9-7692018</a><br class="">irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></blockquote></div><br class=""></span></div></blockquote></div><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br clear="all" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_signature" data-smartmail="gmail_signature" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">Eyal Edri<br class="">Associate Manager</div><div class="">RHEV DevOps<br class="">EMEA ENG Virtualization R&D<br class="">Red Hat Israel<br class=""><br class="">phone: +972-9-7692018<br class="">irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></blockquote></div><br class=""></body></html>