<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 19, 2016 at 1:37 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:mskrivan@redhat.com" target="_blank">mskrivan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On 19 Jul 2016, at 12:15, Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:</div><br><div><div dir="ltr">This happened because you used the same bug for master and 4.0.</div></div></blockquote><div><br></div></span>right, but that’s the regular state of things because upstream there is no separate bug for master vs current version</div><div><span class=""><br><blockquote type="cite"><div><div dir="ltr"><div>The Gerrit hook doesn't verify status between major versions, only inside a single version (for e.g, it would not move to modified if you needed to backport to 4.0.1 and the target milestone was 4.0.1).</div><div>I'm not sure how we can tackle this, because master has no meaning in bugzilla, it doesn't correlate to a version.</div><div><br></div><div>One think I can think of, is NOT to move bugs to MODIFIED is a patch was merged on master branch... , will that help? </div></div></div></blockquote><div><br></div></span>I’m not sure if it’s better because before 4.1 is branched the master development is for 4.1 bugs.</div><div>It would make sense to differentiate based on whether a branch for that TM version exists or not, so in your above example since the bug has TM 4.0.x and there is a 4.0 branch it would wait for a backport</div></div></blockquote><div><br></div><div>I can't compare it to 4.0 because master is a moving target, so this hook will misbehave once master change versions, I need a solid logic that will work all the time for bugs on master.</div><div>either not move them to MODIFIED if the bug is on target milestone != master (which is probably 100% of the times) or some regex we can use... I don't have any other creative ideas...</div><div>You can look at the code if you want at [1] and see if you have an idea.</div><div><br></div><div>[1] <a href="https://gerrit.ovirt.org/gitweb?p=gerrit-admin.git;a=blob;f=hooks/custom_hooks/change-merged.set_MODIFIED;h=678806dc35a372dadab5a5a392d25409db5c8275;hb=refs/heads/master">https://gerrit.ovirt.org/gitweb?p=gerrit-admin.git;a=blob;f=hooks/custom_hooks/change-merged.set_MODIFIED;h=678806dc35a372dadab5a5a392d25409db5c8275;hb=refs/heads/master</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>Thanks,</div><div>michal</div><span class=""><div><br><blockquote type="cite"><div><div dir="ltr"><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 19, 2016 at 8:07 AM, Michal Skrivanek <span dir="ltr"><<a href="mailto:mskrivan@redhat.com" target="_blank">mskrivan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Example in bug <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1357440" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1357440</a><br>
It doesn't take into account branches<br>
<br>
Thanks,<br>
michal<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div>
</div></blockquote></div><br></span></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div>