<div dir="ltr">Looking at the patch, I see:<div><ul class="" style="color:rgb(53,53,53);font-family:sans-serif"><li>Check TM::#1328731::OK, correct target milestone</li></ul><div><font color="#353535" face="sans-serif"><br></font></div><div><font color="#353535" face="sans-serif">Branch is ovirt-engine-3.6</font></div><div><font color="#353535" face="sans-serif">Target Milestone is: ovirt-4.0.2</font></div><div><font color="#353535" face="sans-serif"><br></font></div><div><font color="#353535" face="sans-serif">If we want that hook to give -1 or warn if there is a mismatch between patch and target milestone then we need to fix the hook.</font></div><div><font color="#353535" face="sans-serif">this should exclude master branch, since there is no target milestone for it.</font></div><div><font color="#353535" face="sans-serif"><br></font></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 20, 2016 at 4:10 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">This patch in 3.6 branch contains a 4.0.2 bug in the Bug-Url:<div><br></div><div><a href="https://gerrit.ovirt.org/#/c/60920" target="_blank">https://gerrit.ovirt.org/#/c/60920</a><br></div><div><br></div><div>For some reason the Gerrit hooks approved it and did not block</div><div><br></div></div>
<br>_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div></div>