<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 1, 2016 at 9:56 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
----- Original Message -----<br>
> From: "Juan Hernández" <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>><br>
> To: "Eyal Edri" <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>>, "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>>, "Anton Marchukov" <<a href="mailto:amarchuk@redhat.com">amarchuk@redhat.com</a>><br>
> Cc: "infra" <<a href="mailto:infra@ovirt.org">infra@ovirt.org</a>><br>
> Sent: Monday, August 1, 2016 9:30:23 PM<br>
> Subject: Re: Errors / warnings in ovirt-engine-nodejs-modules build log<br>
><br>
</span><span class="">> On 08/01/2016 09:01 PM, Eyal Edri wrote:<br>
> > Anton, can you sit with Vojtech tomorrow and see if you can help?<br>
> ><br>
> > Vojtech<br>
> > Maybe we're hitting: <a href="http://rpm.org/ticket/862" rel="noreferrer" target="_blank">http://rpm.org/ticket/862</a><br>
> > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=913099" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=913099</a><br>
> ><br>
> > Anyway, what I meant was to try and run it on el7 slaves, not el7 mock,<br>
> > to see if its a regression on mock running on fc24.<br>
> > trying it here to see if it<br>
> > works:<br>
> > <a href="http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/22/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/22/console</a><br>
> ><br>
><br>
> As this seems to be a RPM limitation, and one that isn't going to be<br>
> fixed soon, I'd suggest to change the Node.js modules RPM so that it<br>
> packages a single .tar file containing all the modules. It can then,<br>
> during installation (in the %post) section extract the content to<br>
> /var/lib/ovirt-engine-nodejs-modules, so users only have to change the<br>
> directory they use. Actually, as Vojtech introduced a "setup-env.sh"<br>
> script that does all the preparations, only this script needs to be<br>
> changed. This patch reflects my suggestion:<br>
><br>
> Package tarball containing Node.js modules<br>
> <a href="https://gerrit.ovirt.org/61790" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/61790</a><br>
<br>
</span>+1 this is great!<br>
<br>
Proposed solution doesn't require any change in Dashboard code.<br>
<br>
Seems like it was only a matter of time till we hit that ~100k<br>
files limit when creating ovirt-engine-nodejs-modules RPM.<br></blockquote><div><br></div><div>You may also consider spliitng the rpm in subpackages in a per-module fashion.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Juan++<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> > On Mon, Aug 1, 2016 at 9:42 PM, Vojtech Szocs <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a><br>
> > <mailto:<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>>> wrote:<br>
> ><br>
> ><br>
> ><br>
> > ----- Original Message -----<br>
> > > From: "Eyal Edri" <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a> <mailto:<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>>><br>
> > > To: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a> <mailto:<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>>><br>
> > > Cc: "infra" <<a href="mailto:infra@ovirt.org">infra@ovirt.org</a> <mailto:<a href="mailto:infra@ovirt.org">infra@ovirt.org</a>>><br>
> > > Sent: Monday, August 1, 2016 8:25:50 PM<br>
> > > Subject: Re: Errors / warnings in ovirt-engine-nodejs-modules build<br>
> > > log<br>
> > ><br>
> > > Does it work on el7?<br>
> ><br>
> > It fails on el7 as well:<br>
> ><br>
> > <a href="http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/21/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-el7-x86_64_created/21/console</a><br>
> ><br>
> > error: Unable to create immutable header region.<br>
> ><br>
> > ><br>
> > > On Mon, Aug 1, 2016 at 8:21 PM, Vojtech Szocs <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a><br>
> > <mailto:<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>>> wrote:<br>
> > ><br>
> > > > Forwarding to infra, TL;DR we seem to have an issue with rpmbuild<br>
> > > > (see below) and I'm not sure how to fix that, is there anyone who<br>
> > > > faced such issue in past?<br>
> > > ><br>
> > > > Vojtech<br>
> > > ><br>
> > > ><br>
> > > > ----- Forwarded Message -----<br>
> > > > From: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a><br>
> > > > <mailto:<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>>><br>
> > > > To: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a><br>
> > <mailto:<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>>><br>
> > > > Cc: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a><br>
> > <mailto:<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>>>, "Alexander Wels" <<br>
> > > > <a href="mailto:awels@redhat.com">awels@redhat.com</a> <mailto:<a href="mailto:awels@redhat.com">awels@redhat.com</a>>>, "Greg Sheremeta"<br>
> > <<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a> <mailto:<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>>>, "Juan<br>
> > > > Hernández" <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a> <mailto:<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>>>,<br>
> > "Ryan Barry" <<a href="mailto:rbarry@redhat.com">rbarry@redhat.com</a> <mailto:<a href="mailto:rbarry@redhat.com">rbarry@redhat.com</a>>><br>
> > > > Sent: Monday, August 1, 2016 6:49:08 PM<br>
> > > > Subject: Errors / warnings in ovirt-engine-nodejs-modules build log<br>
> > > ><br>
> > > > Hi Sandro,<br>
> > > ><br>
> > > > I've looked into the build log [1].<br>
> > > ><br>
> > > > Adding Juan & Ryan as well. Your feedback is highly appreciated.<br>
> > > ><br>
> > > > npm-specific issues (don't block the build):<br>
> > > ><br>
> > > > npm WARN package.json dependencies@ No repository field.<br>
> > > > npm WARN package.json dependencies@ No license field.<br>
> > > > - these warnings are harmless<br>
> > > > - TODO update modules' package.json<br>
> > > ><br>
> > > > npm WARN deprecated ...<br>
> > > > - some (possibly transitive) dependency in package.json relies<br>
> > > > on a deprecated npm package<br>
> > > > - TODO find out which dependencies are causing this<br>
> > > ><br>
> > > > npm ERR! registry error parsing json<br>
> > > > - this might indicate corrupt npm cache<br>
> > > > - should be fixed by `npm cache clean`<br>
> > > > - TODO update modules' build.sh<br>
> > > ><br>
> > > > npm WARN optional dep failed, continuing ...<br>
> > > > - these warnings are harmless<br>
> > > > - some (possibly transitive) dependency in package.json relies<br>
> > > > on an optional npm package that is platform-specific but it<br>
> > > > is NOT available for current platform<br>
> > > > - e.g. "fsevents" is MacOSX only<br>
> > > > - this should be fixed by `npm install --no-optional`<br>
> > > > - TODO update modules' build.sh<br>
> > > ><br>
> > > > sh: bower: command not found<br>
> > > > npm WARN optional dep failed, continuing bootstrap-treeview@1.2.0<br>
> > > > - bootstrap-treeview does `bower install` in its `install` script<br>
> > > > - this is BAD practice (bootstrap-treeview's fault)<br>
> > > > - TODO latest commit on May 9, 2015 -- do we need this at all (?)<br>
> > > ><br>
> > > > CI-specific issues (which block the build):<br>
> > > ><br>
> > > > Wrote:<br>
> > > ><br>
> > /tmp/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules-0.0.10-1.fc24.src.rpm<br>
> > > > error: Unable to create immutable header region.<br>
> > > > - at this point, spec's %install phase has finished executing<br>
> > > > and RPM was created<br>
> > > > - it is rpmbuild related, see<br>
> > > > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=913099#c2" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=913099#c2</a><br>
> > > ><br>
> > > > For ^^ error, seems like too many files in RPM package will cause<br>
> > > > "artificial cap on header size" to be exceeded and rpmbuild fails.<br>
> > > ><br>
> > > > Juan, what do you think? I don't have any idea how to solve this.<br>
> > > ><br>
> > > > I don't understand the actual issue as we're creating single .tar<br>
> > > > file from `node_modules` directory during the RPM build..<br>
> > > ><br>
> > > > [1]<br>
> > > ><br>
> > <a href="http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-fc24-x86_64_created/4/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine-nodejs-modules_master_create-rpms-fc24-x86_64_created/4/console</a><br>
> > > ><br>
> > > > Thanks,<br>
> > > > Vojtech<br>
> > > > _______________________________________________<br>
> > > > Infra mailing list<br>
> > > > <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a> <mailto:<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a>><br>
> > > > <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > ><br>
> > ><br>
> > > --<br>
> > > Eyal Edri<br>
> > > Associate Manager<br>
> > > RHV DevOps<br>
> > > EMEA ENG Virtualization R&D<br>
> > > Red Hat Israel<br>
> > ><br>
> > > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a> <tel:%2B972-9-7692018><br>
> > > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> > ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Eyal Edri<br>
> > Associate Manager<br>
> > RHV DevOps<br>
> > EMEA ENG Virtualization R&D<br>
> > Red Hat Israel<br>
> ><br>
> > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > Infra mailing list<br>
> > <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> > <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
> ><br>
><br>
><br>
> --<br>
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
> 3ºD, 28016 Madrid, Spain<br>
> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
><br>
_______________________________________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></div>