<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 18, 2016 at 4:54 PM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, Aug 9, 2016 at 12:36 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Adding infra also, as might be relevant for our code.</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Tue, Aug 9, 2016 at 11:06 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Hi,<div>in project maintained by integration team we tried to adhere to some styling rules while writing python code, one of these was related to the import lines. After a lot of time doing this manually, we discovered isort ( <a href="https://pypi.python.org/pypi/isort/4.2.5" target="_blank">https://pypi.python.org/pypi<wbr>/isort/4.2.5</a> )</div><div><br></div></div></div></div></blockquote></div></div></blockquote><div><br></div></span><div>Available in fedora 24 updates-testing as python-isort, should land to stable pretty soon.</div><span class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div></div><div>We're using it before we push our code to gerrit and a few days ago I sent a patch for the python code within ovirt-engine: <a href="https://gerrit.ovirt.org/61964" target="_blank">https://gerrit.o<wbr>virt.org/61964</a></div></div></div></div></blockquote></div></div></blockquote><div><br></div></span><div>Going to merge this tomorrow.</div><span class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><br></div><div>The configuration we're currently using is:</div><div><br></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">$ cat ~/.isort.cfg
[settings]
line_length=79
known_standard_library=configp<wbr>arser,Cheetah.Template
force_single_line=True
default_section=FIRSTPARTY
known_otopi=otopi
known_host_deploy=ovirt_host_d<wbr>eploy
known_ovirt_engine=ovirt_engin<wbr>e
known_ovirt_engine_setup=ovirt<wbr>_engine_setup
known_ovirt_setup_lib=ovirt_se<wbr>tup_lib
known_vdsm=vdsm
known_ovirt_hosted_engine_setu<wbr>p=ovirt_hosted_engine_setup
sections=FUTURE,STDLIB,FIRSTPA<wbr>RTY,OTOPI,VDSM,HOST_DEPLOY,OVI<wbr>RT_ENGINE,OVIRT_ENGINE_SETUP,<wbr>OVIRT_SETUP_LIB,OVIRT_HOSTED_<wbr>ENGINE_SETUP,THIRDPARTY,<wbr>LOCALFOLDER
lines_between_types=2</span></div><div><font color="#353535" face="monospace"><span style="white-space:pre-wrap"><br></span></font></div>It has been proposed to add 'isort --check-only' in check-patch.for python projects in addition to pep8 style checking.<br></div></div></div></blockquote></div></div></blockquote><div><br></div><div><br></div></span><div>No objections, I take this as approved. Opening a ticket.</div></div></div></div></blockquote><div><br></div><div>isort --check-only has been added to ovirt-engine check-patch.</div><div>Please be sure to rebase your patch if it fails complaining about incorrect ordering of imports</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><br>It has also been proposed to reach consensus on isort configuration so all the python code<br>within ovirt project will have same styling.<br></div></div></div></blockquote></div></div></blockquote><div><br></div></span><div>No suggestions, I take proposed config as approved as a start. We can amend it later on.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><br>I'd like to get some feedback about these proposal in order to decide how to procede.<br><br>Thanks,<span><font color="#888888"><div><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></font></span></div>
<br></div></div>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><span><font color="#888888"><br></font></span></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</font></span></div>
</blockquote></span></div><span class=""><br><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></div>