<div dir="ltr">Yep, you are right the hook is check_target_milestone and i explained it in the previous email.<div><br></div><div>So after i've made some checks these are my conclusions:</div><div><ul><li>All the new hooks are performing manipulation only on bugs with u/s classification (oVirt), the bug [1] is with a d/s classification.<br></li><li>The '<i style="font-size:12.8px">Check merged to previous' </i><span style="font-size:12.8px">hook is an old hook that is not configured to check classifications.</span></li></ul></div><div><span style="font-size:12.8px">[1] </span><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1368101" target="_blank" style="font-size:12.8px">https://bugzilla.redhat.<wbr>com/show_bug.cgi?id=1368101</a> </div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Best Regards,</div><div dir="ltr"><br></div><div dir="ltr">Shlomi Ben-David | DevOps Engineer <span style="font-size:small">| </span><span style="font-size:12.8px">Red Hat ISRAEL</span></div><div>RHCSA | <span style="font-size:small">RHCE</span><span style="font-size:small"> </span><span style="font-size:12.8px"> </span></div><div dir="ltr">IRC: shlomibendavid <span style="font-size:small">(on #rhev-integ, #rhev-dev, #rhev-ci)</span><br><br>OPEN SOURCE - 1 4 011 && 011 4 1<br></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Sun, Oct 30, 2016 at 3:50 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">I think its this one: <a href="https://gerrit.ovirt.org/#/c/64538/" target="_blank">https://gerrit.ovirt.org/<wbr>#/c/64538/</a><div><br></div><div>And I think I know what the problem is, </div><div>This bug [1] is 4.1 bug its target milestone is 4.0.6 because its a clone candidate bug.</div><div>Shlomi - IIRC we addressed that issue in the hook, can you verify? (also, might be the bug is ignoring downstream bugs)</div><div><br></div><div><br></div><div><br></div><div>[1] <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1368101" target="_blank">https://bugzilla.redhat.<wbr>com/show_bug.cgi?id=1368101</a></div></div><div class="gmail-HOEnZb"><div class="gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 30, 2016 at 3:35 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Shlomi - do we have a gerrit hook that checks the bug version with the branch name? <div>I remember we had something similar... </div></div><div class="gmail-m_-5909821865997932427HOEnZb"><div class="gmail-m_-5909821865997932427h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 30, 2016 at 3:30 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">That was an example, the patch should have got -verified as a 4.1 bug url in a 4.0.5 branch</div><div class="gmail-m_-5909821865997932427m_6956620802079378643HOEnZb"><div class="gmail-m_-5909821865997932427m_6956620802079378643h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 30, 2016 at 3:27 PM, Shlomo Ben David <span dir="ltr"><<a href="mailto:sbendavi@redhat.com" target="_blank">sbendavi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Tal: The '<i>Check merged to previous</i>' hook is checking if the current patch was merged to previous stable branches and i think that it is not related to the one that you're searching.</div><div><br></div><div>Eyal: Currently there is no hook that checks if branch is enabled, but there is hook that checks if the patch major version branch is [equal / higher / lower] than the bug target milestone major version.</div><div>i'll explain by giving you few examples and their results:</div><div><br></div><div><div>Example 1:</div><div>tm: '---' (empty target milestone)</div><div>branch major version: any</div><div>result: <font color="#ff0000"><b>WARN MSG</b></font></div><div><br></div><div>Example 2:</div><div>tm major version: 3.6</div><div>branch major version: 3.6</div><div>result: <font color="#00ff00"><b>OK MSG</b></font></div><div> </div><div>Example 3:</div><div>tm major version: 3.6</div><div>branch major version: 4.0</div><div>result: checks for clone flags </div><div>(if tm major version in flags - <font color="#00ff00"><b>OK MSG</b></font> else <font color="#ff0000"><b>WARN MSG</b></font>)</div><div> </div><div>Example 4:</div><div>tm major version: 4.0</div><div>branch major version: 3.6</div><div>result: <font color="#ff0000"><b>WARN MSG</b></font></div></div><div><br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Best Regards,</div><div dir="ltr"><br></div><div dir="ltr">Shlomi Ben-David | DevOps Engineer <span style="font-size:small">| </span><span style="font-size:12.8px">Red Hat ISRAEL</span></div><div>RHCSA | <span style="font-size:small">RHCE</span><span style="font-size:small"> </span><span style="font-size:12.8px"> </span></div><div dir="ltr">IRC: shlomibendavid <span style="font-size:small">(on #rhev-integ, #rhev-dev, #rhev-ci)</span><br><br>OPEN SOURCE - 1 4 011 && 011 4 1<br></div></div></div></div></div></div></div></div></div></div><div><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995h5">
<br><div class="gmail_quote">On Sun, Oct 30, 2016 at 9:45 AM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Shlomi, <div>Can you check if we have the hook for verifying right branch is enabled? </div><div><br></div><div><br></div></div><div class="gmail_extra"><div><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307h5"><br><div class="gmail_quote">On Thu, Oct 27, 2016 at 11:00 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">This patch was pushed to 4.0.5 with a bug that at the time of the push was 4.1, Gerrit hooks should have marked it as -verified, instead you get:<div><ul class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307m_8370991219207361263m_-1851721314793783974gmail-com-google-gwtexpui-safehtml-client-SafeHtmlCss-wikiList" style="color:rgb(53,53,53);font-family:sans-serif"><li>Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.6', 'ovirt-engine-4.0', 'ovirt-engine-3.6.9', 'ovirt-engine-4.0.2', 'ovirt-engine-4.0.4'])</li></ul></div></div><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307m_8370991219207361263HOEnZb"><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307m_8370991219207361263h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 27, 2016 at 9:55 AM, Gil Shinar <span dir="ltr"><<a href="mailto:gshinar@redhat.com" target="_blank">gshinar@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Can you please elaborate?<div><br></div><div>Thanks</div><div>Gil</div></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 26, 2016 at 11:50 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span><div dir="ltr">This patch for example:<div><a href="https://gerrit.ovirt.org/#/c/65398/" target="_blank">https://gerrit.ovirt.org/#/c/6<wbr>5398/</a><br></div><div><br></div></div>
<br></span>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307HOEnZb"><font color="#888888">-- <br><div class="gmail-m_-5909821865997932427m_6956620802079378643m_-4418409709296026995m_-5117096904444635307m_8370991219207361263gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</font></span></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-5909821865997932427m_6956620802079378643gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-5909821865997932427gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>
</div></div></blockquote></div><br></div></div>