<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 23, 2016 at 10:26 AM, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 11/23/2016 09:16 AM, Eyal Edri wrote:<br>
> Maybe worth adding the build artifacts to check-patch.sh so you'll see<br>
> it before merge?<br>
><br>
<br>
</span>The check-patch.sh script already runs the build of the artifacts. The<br>
problem is that in this case the "bug" was in the automation<br>
build-artifacts.sh script itself, and it only runs when the patch is<br>
merged. The reason for running the build-artifacts.sh script only when<br>
the patch is merged is that it runs a heavy process: generation of<br>
documentation using Publican. I didn't want to do that for every patch,<br>
as it consumes a lot of resources and doesn't add anything in terms of<br>
patch verification.<br></blockquote><div><br></div><div>Gating will help with that, we're working on it now, you can be a beta tested for the api project if you want :)</div><div>So basically you'll have a flag in gerrit to trigger the pre-merge jobs and if the job will fail the patch won't merge.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Actually I am currently using the build-artifacts.sh script where I<br>
should probably use the check-merged.sh script. I think I need to<br>
reorganize the jobs and the automation scripts to make this clearer. I<br>
am working on that.<br>
<span class=""><br>
> On Wed, Nov 23, 2016 at 10:10 AM, Juan Hernández <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a><br>
</span><span class="">> <mailto:<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>>> wrote:<br>
><br>
> On 11/23/2016 08:29 AM, Sandro Bonazzola wrote:<br>
> ><br>
> <a href="http://jenkins.ovirt.org/job/ovirt-engine-api-model_4.0_build-artifacts-fc24-x86_64/30/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine-api-model_4.0_<wbr>build-artifacts-fc24-x86_64/<wbr>30/console</a><br>
> <<a href="http://jenkins.ovirt.org/job/ovirt-engine-api-model_4.0_build-artifacts-fc24-x86_64/30/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine-api-model_4.0_<wbr>build-artifacts-fc24-x86_64/<wbr>30/console</a>><br>
> ><br>
> > *<br>
> > *<br>
> ><br>
> > *<br>
> > *<br>
> ><br>
> > *00:04:35.993* + mv target/model.json exported-artifacts<br>
> > *00:04:35.993* mv: cannot stat 'target/model.json': No such file<br>
> or directory<br>
> > *00:04:35.993* Took 93 seconds<br>
> ><br>
> ><br>
> > Can you please have a look?<br>
> ><br>
><br>
><br>
> That should be addressed by the following patch:<br>
><br>
> Fix automation scripts after removing 'describe' profile<br>
> <a href="https://gerrit.ovirt.org/67208" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/67208</a><br>
><br>
> --<br>
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
> 3ºD, 28016 Madrid, Spain<br>
> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat<br>
> S.L.<br>
> ______________________________<wbr>_________________<br>
> Infra mailing list<br>
</span>> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a> <mailto:<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a>><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a><br>
<span class="im HOEnZb">> <<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a>><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> RHV DevOps<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
<br>
<br>
</span><div class="HOEnZb"><div class="h5">--<br>
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
3ºD, 28016 Madrid, Spain<br>
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>