<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 10:53 AM, Roy Golan <span dir="ltr"><<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On 12 December 2016 at 11:50, Piotr Kliczewski <span dir="ltr"><<a href="mailto:pkliczew@redhat.com" target="_blank">pkliczew@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Dec 12, 2016 at 10:34 AM, Roy Golan <span dir="ltr"><<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 11 December 2016 at 13:30, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On 12/11/2016 12:27 PM, Eyal Edri wrote:<br>
> Which maven repository does vdsm-jsonrpc-java is using in its automation<br>
> scripts?<br>
><br>
<br>
</span>That project uses "maven-local" to build, and takes the dependencies<br>
from the RPM .spec file, not for the POM. So you need to make sure that<br>
the package for checkstyle is listed in as a "BuildRequires" in the<br>
.<a href="http://spec.in" rel="noreferrer" target="_blank">spec.in</a> file. As far as I know there is no package containing<br>
checkstyle for EL7, at least not in the standard repositories. So this<br>
will always fail, unless you explicity remove the checkstyle plugin when<br>
building in EL7.<br></blockquote><div><br></div><div>Thanks Juan.<br>Piotr, Juan do you have insights on why the project is structured like that at all and why can't this be <br></div><div>simple mvn project and a simple makefile without this voodo?<br></div></div></div></div></blockquote><div><br></div></span>It was suggested by fedora packager as part of work to have it released on fedora repo.<br></div><div class="gmail_quote">This work is still in progress [1] but we are almost there.<br><br></div></div></div></blockquote><div><br></div></span><div>And why do we have to have the <a href="http://pom.xml.in" target="_blank">pom.xml.in</a>? just to template the name? can we get rid of it please?<br></div></div></div></div></blockquote><div><br></div><div>What would be the reason to get rid of it?<br><br>Thanks to this approach we change version only in <a href="http://configure.ac">configure.ac</a> file<br></div><div>and without it we would need to change it in few places like we do in the engine.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">[1] <a href="https://gerrit.ovirt.org/#/c/63673/" target="_blank">https://gerrit.ovirt.org/#/c/6<wbr>3673/</a><br></div><div><div class="m_-6320312065275613062h5"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span><br>
> On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a><br>
</span><span>> <mailto:<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>>> wrote:<br>
><br>
> This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc<br>
> but it keep complaining [2] it can't resolve it . The plugin is the<br>
> same version, 2.9.1 as ovirt engine uses. The F24 build is passing.<br>
> What am I missing here?<br>
><br>
> [1] <a href="https://gerrit.ovirt.org/67990" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/67990</a><br>
> [2]<br>
> <a href="http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/100/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>vdsm-jsonrpc-java_master_check<wbr>-patch-el7-x86_64/100/console</a><br>
> <<a href="http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/100/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job<wbr>/vdsm-jsonrpc-java_master_chec<wbr>k-patch-el7-x86_64/100/console</a><wbr>><br>
><br>
><br>
><br>
> _____________________________<wbr>__________________<br>
> Infra mailing list<br>
</span>> <a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a> <mailto:<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a>><br>
> <a href="http://lists.phx.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.phx.ovirt.org/ma<wbr>ilman/listinfo/infra</a><br>
<div class="m_-6320312065275613062m_587471536556765014gmail-m_-7802982495521673007HOEnZb"><div class="m_-6320312065275613062m_587471536556765014gmail-m_-7802982495521673007h5">> <<a href="http://lists.phx.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.phx.ovirt.org/m<wbr>ailman/listinfo/infra</a>><br>
><br>
><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> RHV DevOps<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
> <a href="http://lists.phx.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.phx.ovirt.org/mai<wbr>lman/listinfo/infra</a><br>
><br>
<br>
</div></div></blockquote></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>