<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Last night I've push a serious of patches and forgot to sign off, up until not long ago there was a hook that enforces that but it seems like it's not working anymore and I was able to push the patches without the sign off:<div><a href="https://gerrit.ovirt.org/#/c/69219/1" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>69219/1</a><br></div><div><br></div></div></blockquote><div><br></div><div>Its not a hook, its a definition per project, each project has the defenition if to enforce signed-off commit:</div><div><br></div><div>'Require Signed-off-by in commit message:' - and its on TRUE now for ovirt-engine, so I'm not sure how its possible that a patch got in, we'll need to check gerrit logs to see.<br></div><div>Opening a ticket on it.</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div></div>
<br>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>