<div dir="ltr">Opening a ticket on it. <div>We'll need to check which params to override in the new comment added trigger to not give +1. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 16, 2017 at 10:01 PM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 16 January 2017 at 16:14, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
><br>
><br>
> On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <<a href="mailto:gshinar@redhat.com">gshinar@redhat.com</a>> wrote:<br>
>><br>
>> Edy showed me the issue. I think we haven't thought about that.<br>
>> 'ci please build' actually executes build artifacts jobs and when they<br>
>> succeed, they change the "continuous integration" flag to +1.<br>
>><br>
>> Can we control it from the Gerrit?<br>
<br>
</span>No need we can do it from the job.<br>
<span class=""><br>
> I couldn't find any reference for response from Jenkins to Grrit in the yaml<br>
> templates in std CI, so not sure its configurable per job, it might be on<br>
> the main Jenkins configuration.<br>
> Barak - do you know where the grading is defined for Gerrit Trigger in YAML?<br>
<br>
</span>Yeah you can use 'skip-vote" [1].<br>
This requires Gerrit Trigger Plugin version >= 2.7.0<br>
<br>
[1]: <a href="http://docs.openstack.org/infra/jenkins-job-builder/triggers.html#triggers.gerrit" rel="noreferrer" target="_blank">http://docs.openstack.org/<wbr>infra/jenkins-job-builder/<wbr>triggers.html#triggers.gerrit</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
<br>
<br>
--<br>
Barak Korren<br>
<a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a><br>
RHCE, RHCi, RHV-DevOps Team<br>
<a href="https://ifireball.wordpress.com/" rel="noreferrer" target="_blank">https://ifireball.wordpress.<wbr>com/</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>