<div dir="ltr">+1, thanks.<div><br></div><div>Please continue to let us know if we need to enforce other hooks more strictly as well :)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 30, 2017 at 3:29 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yeah I've noticed the hook identified the situation, I'm asking you to make it more stricter, hence the email :)</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 30, 2017 at 3:22 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It already WARN on it: <ul class="m_8215661672071967422m_-321758524637064304gmail-com-google-gwtexpui-safehtml-client-SafeHtmlCss-wikiList" style="color:rgb(53,53,53);font-family:sans-serif"><li>Check TM::#1416309::WARN, wrong target milestone: ovirt-4.2.0<br></li></ul><div>We can make it more strict and give VERIFY -1.<br></div><div>Adding infra-support to open a ticket on it.</div><div><br></div><div>We intentionally didn't enforce Verify as default since we wanted to give time to the hook </div><div>to work and see we don't have false positives on it.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_8215661672071967422h5">On Mon, Jan 30, 2017 at 3:13 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_8215661672071967422h5"><div dir="ltr">Example:<div><a href="https://gerrit.ovirt.org/#/c/71374/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>1374/</a><br></div><div><br></div><div>I'd expect the Gerrit hooks to give -1 on verified when a 4.2 bug is pushed into the 4.1 stable branch</div><div><br></div><div>Thanks.</div></div>
<br></div></div>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
<br></blockquote></div><span class="m_8215661672071967422HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_8215661672071967422m_-321758524637064304gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>