<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">Il 24/Feb/2017 19:37, "Barak Korren" <<a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a>> ha scritto:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Sorry, but I really don't think this is the right direction to go.<div dir="auto"><br></div><div dir="auto">This exposes check-patch to outside repos and may result in repo-stability-related failures after we've made great efforts to eliminate those.</div><div dir="auto"><br></div><div dir="auto">This kind of test should really be done at the OST stage IMO.</div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">OST come into play too late, with patch already merged and dep tree broken. It will avoid the rpm to be published but it will fail the subsequent ost hiding other issues. Any suggestion on how to avoid it? Run OST in check patch?</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"> I haven't merged the patches becauseI wanted feedback like this, thanks Barack. </div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><br><div class="gmail_quote">בתאריך 24 בפבר׳ 2017 18:01, "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>> כתב:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 24, 2017 at 4:59 PM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div>with the following commits:</div><div>- <a href="https://gerrit.ovirt.org/71553" target="_blank">https://gerrit.ovirt.org/71553</a></div><div>- <a href="https://gerrit.ovirt.org/71623" target="_blank">https://gerrit.ovirt.org/71623</a></div><div><br></div><div>a minimal repository closure check is added to check-patches.sh.</div><div>Instead of performing a full blown repository closure, I limited the check to the built rpms in oreder to reduce the risk of hitting repository closure errors due to different projects.</div><div><br></div><div>This should help dropping the long time failing repository closure jobs which are struggling to keep the pace with the changes we introduce in master.</div><div>It should also help avoiding to merge patches which will break the repository and the plain rpm install flow.<br clear="all"></div></div></blockquote><div><br></div><div>Forgot to mention I recomend to steal the check for your own project reducing repository closure issues as well :-)</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div>The second patch switch from ovirt-master-release to experimental repo.</div><div>Here I need infra input, not sure experimental is the desired repo, deisgned to replace ovirt-master-snapshot.</div><div><br></div><div>Thanks,</div><span class="m_6055936332855917286m_-1525606341692432865HOEnZb"><font color="#888888">-- <br><div class="m_6055936332855917286m_-1525606341692432865m_2548252486454399247gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_6055936332855917286m_-1525606341692432865gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</div></div>
<br></div>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
<br></blockquote></div></div>
</blockquote></div><br></div></div></div>